Issue 21071. Generate posix-style relative URIs.

Issue 21071. Generate posix-style relative URIs.

But parse using the target file system's Context.

R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21071

Committed: https://code.google.com/p/dart/source/detail?r=40655

[Paul Berry, 2014-09-24 21:31:08]

lgtm

https://codereview.chromium.org/603753002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/refactoring/move_file.dart (right):

https://codereview.chromium.org/603753002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/refactoring/move_file.dart:131: if
(pathContext.isAbsolute(path)) {
Nit: the correctness of this code relies on the fact that
pathContext.isAbsolute() returns false if it's presented with a URI.  It seeems
a little problematic to rely on that since pathContext.isAbsolute() is only
expecting to be passed proper filenames.

Perhaps it would be better to do something like this:

Uri uri = Uri.parse(path);
if (uri.scheme == '') {
  return !pathContext.isAbsolute(path);
} else {
  return !uri.isAbsolute;
}

Your call, though.

[scheglov, 2014-09-24 22:21:27]

https://codereview.chromium.org/603753002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/refactoring/move_file.dart (right):

https://codereview.chromium.org/603753002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/refactoring/move_file.dart:131: if
(pathContext.isAbsolute(path)) {
On 2014/09/24 21:31:08, Paul Berry wrote:
> Nit: the correctness of this code relies on the fact that
> pathContext.isAbsolute() returns false if it's presented with a URI.  It
seeems
> a little problematic to rely on that since pathContext.isAbsolute() is only
> expecting to be passed proper filenames.
> 
> Perhaps it would be better to do something like this:
> 
> Uri uri = Uri.parse(path);
> if (uri.scheme == '') {
>   return !pathContext.isAbsolute(path);
> } else {
>   return !uri.isAbsolute;
> }
> 
> Your call, though.

Acknowledged.

[scheglov, 2014-09-24 22:23:11]

Committed patchset #2 (id:20001) manually as 40655 (presubmit successful).