Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 603703002: Fix SurfaceResourceHolder destruction order (Closed)

Created:
6 years, 3 months ago by jamesr
Modified:
6 years, 3 months ago
Reviewers:
jbauman
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix SurfaceResourceHolder destruction order cc::Surface instances in the surface map have raw pointers to the surface holder, so the holder needs to outlive the map. BUG=417325 Committed: https://crrev.com/dd9b6605c8b7daac33a2463030c5d2b86ef834f6 Cr-Commit-Position: refs/heads/master@{#296486}

Patch Set 1 #

Patch Set 2 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M cc/surfaces/surface_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/surfaces/surface_factory_unittest.cc View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jamesr
6 years, 3 months ago (2014-09-24 18:36:18 UTC) #2
jbauman
lgtm
6 years, 3 months ago (2014-09-24 19:06:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603703002/20001
6 years, 3 months ago (2014-09-24 19:08:49 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as c6d80ea7d1c151fef0a1ee460503139e86c610c9
6 years, 3 months ago (2014-09-24 19:25:19 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 19:26:22 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dd9b6605c8b7daac33a2463030c5d2b86ef834f6
Cr-Commit-Position: refs/heads/master@{#296486}

Powered by Google App Engine
This is Rietveld 408576698