Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 603693002: Compile third_party/jstemplate with Closure Compiler (Closed)

Created:
6 years, 3 months ago by Vitaly Pavlenko
Modified:
6 years, 2 months ago
CC:
chromium-reviews, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org, Dan Beam
Base URL:
https://chromium.googlesource.com/chromium/src.git@true_master
Project:
chromium
Visibility:
Public.

Description

Compile third_party/jstemplate/ with Closure Compiler R=arv@chromium.org BUG=393873 TEST=GYP_GENERATORS=ninja gyp --depth . third_party/jstemplate/compiled_resources.gyp && ninja -C out/Default Committed: https://crrev.com/51a0be3f517537580b83752b7c569d163f42216d Cr-Commit-Position: refs/heads/master@{#297018}

Patch Set 1 #

Patch Set 2 : fix in gyp file #

Total comments: 4

Patch Set 3 : switch some types to ANY #

Patch Set 4 : two other fixes #

Total comments: 2

Patch Set 5 : Element -> {Element} #

Total comments: 2

Patch Set 6 : object -> result #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -48 lines) Patch
A + third_party/jstemplate/compiled_resources.gyp View 1 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/jstemplate/jsevalcontext.js View 1 2 3 6 chunks +18 lines, -18 lines 0 comments Download
M third_party/jstemplate/jstemplate.js View 1 2 3 4 4 chunks +6 lines, -13 lines 0 comments Download
M third_party/jstemplate/util.js View 1 2 3 4 5 7 chunks +16 lines, -12 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Vitaly Pavlenko
arv@, please, review
6 years, 3 months ago (2014-09-24 17:58:19 UTC) #2
arv (Not doing code reviews)
https://chromiumcodereview.appspot.com/603693002/diff/20001/third_party/jstemplate/jsevalcontext.js File third_party/jstemplate/jsevalcontext.js (right): https://chromiumcodereview.appspot.com/603693002/diff/20001/third_party/jstemplate/jsevalcontext.js#newcode268 third_party/jstemplate/jsevalcontext.js:268: * @param {Object|number|null} value should this be any? https://chromiumcodereview.appspot.com/603693002/diff/20001/third_party/jstemplate/util.js ...
6 years, 2 months ago (2014-09-25 18:46:53 UTC) #3
Vitaly Pavlenko
https://chromiumcodereview.appspot.com/603693002/diff/20001/third_party/jstemplate/jsevalcontext.js File third_party/jstemplate/jsevalcontext.js (right): https://chromiumcodereview.appspot.com/603693002/diff/20001/third_party/jstemplate/jsevalcontext.js#newcode268 third_party/jstemplate/jsevalcontext.js:268: * @param {Object|number|null} value On 2014/09/25 18:46:53, arv wrote: ...
6 years, 2 months ago (2014-09-25 20:24:42 UTC) #4
Dan Beam
https://chromiumcodereview.appspot.com/603693002/diff/60001/third_party/jstemplate/jstemplate.js File third_party/jstemplate/jstemplate.js (right): https://chromiumcodereview.appspot.com/603693002/diff/60001/third_party/jstemplate/jstemplate.js#newcode866 third_party/jstemplate/jstemplate.js:866: return /** @type Element */(x); shouldn't this be @type ...
6 years, 2 months ago (2014-09-26 02:23:10 UTC) #6
Vitaly Pavlenko
https://chromiumcodereview.appspot.com/603693002/diff/60001/third_party/jstemplate/jstemplate.js File third_party/jstemplate/jstemplate.js (right): https://chromiumcodereview.appspot.com/603693002/diff/60001/third_party/jstemplate/jstemplate.js#newcode866 third_party/jstemplate/jstemplate.js:866: return /** @type Element */(x); On 2014/09/26 02:23:09, Dan ...
6 years, 2 months ago (2014-09-26 18:31:39 UTC) #8
Dan Beam
lgtm, please never show me this code again https://chromiumcodereview.appspot.com/603693002/diff/80001/third_party/jstemplate/util.js File third_party/jstemplate/util.js (right): https://chromiumcodereview.appspot.com/603693002/diff/80001/third_party/jstemplate/util.js#newcode58 third_party/jstemplate/util.js:58: var ...
6 years, 2 months ago (2014-09-26 19:10:30 UTC) #10
Vitaly Pavlenko
https://chromiumcodereview.appspot.com/603693002/diff/80001/third_party/jstemplate/util.js File third_party/jstemplate/util.js (right): https://chromiumcodereview.appspot.com/603693002/diff/80001/third_party/jstemplate/util.js#newcode58 third_party/jstemplate/util.js:58: var object = eval('[' + expr + '][0]'); On ...
6 years, 2 months ago (2014-09-26 19:46:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603693002/100001
6 years, 2 months ago (2014-09-26 19:47:27 UTC) #13
commit-bot: I haz the power
Committed patchset #6 (id:100001) as f9826bb55e9e73cd4b9d9b3a80b331ab2150feec
6 years, 2 months ago (2014-09-26 20:18:16 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 20:18:49 UTC) #15
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/51a0be3f517537580b83752b7c569d163f42216d
Cr-Commit-Position: refs/heads/master@{#297018}

Powered by Google App Engine
This is Rietveld 408576698