Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 603673003: Apply automatic range checks to storage enum types across IPC. (Closed)

Created:
6 years, 3 months ago by anujsharma
Modified:
6 years, 2 months ago
Reviewers:
nasko, piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Apply automatic range checks to storage enum types across IPC. This is part of a long-running background task to remove the remaining uses of the unchecked IPC_ENUM_TRAITS() macro. BUG=246708 Committed: https://crrev.com/23ba66181008a9d9b40c7df97cc2497b7a82ac6f Cr-Commit-Position: refs/heads/master@{#296887}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/common/fileapi/file_system_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M storage/common/quota/quota_types.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
anujsharma
piman@chromium.org: Please review changes in storage module nasko@chromium.org: Please review changes in content module
6 years, 3 months ago (2014-09-25 09:00:37 UTC) #2
nasko
LGTM
6 years, 2 months ago (2014-09-25 16:27:30 UTC) #3
piman
lgtm
6 years, 2 months ago (2014-09-25 17:57:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603673003/1
6 years, 2 months ago (2014-09-26 03:21:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 587592085e6b30193c99d63dd3e1940d33b29f6d
6 years, 2 months ago (2014-09-26 05:04:37 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 05:05:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23ba66181008a9d9b40c7df97cc2497b7a82ac6f
Cr-Commit-Position: refs/heads/master@{#296887}

Powered by Google App Engine
This is Rietveld 408576698