Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issue 603663002: OutputSurfaceMojo should bind its SurfacePtr on the impl thread (Closed)

Created:
6 years, 2 months ago by abarth-chromium
Modified:
6 years, 2 months ago
Reviewers:
jamesr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, cc-bugs_chromium.org, ben+mojo_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

OutputSurfaceMojo should bind its SurfacePtr on the impl thread We can't call set_client on the main thread because that determines the thread affinity of the SurfacePtr. Instead, we need to wait for the BindToClient callback so we can bind the SurfacePtr on the impl thread. R=jamesr@chromium.org Committed: https://crrev.com/faa1c522af8be7a3993bca1399a8d99c492d3185 Cr-Commit-Position: refs/heads/master@{#296474}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M mojo/cc/output_surface_mojo.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/cc/output_surface_mojo.cc View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
abarth-chromium
6 years, 2 months ago (2014-09-24 17:27:01 UTC) #1
jamesr
lgtm
6 years, 2 months ago (2014-09-24 17:28:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603663002/1
6 years, 2 months ago (2014-09-24 17:33:22 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 02612a6dd65c10693c9f6b725ac92323b89a3f99
6 years, 2 months ago (2014-09-24 18:32:10 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-09-24 18:33:03 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/faa1c522af8be7a3993bca1399a8d99c492d3185
Cr-Commit-Position: refs/heads/master@{#296474}

Powered by Google App Engine
This is Rietveld 408576698