Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 603643002: DevTools: properly inject elements panel context menu items. (Closed)

Created:
6 years, 2 months ago by pfeldman
Modified:
6 years, 2 months ago
Reviewers:
sergeyv
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: properly inject elements panel context menu items. BUG=417275 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182620

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review comment addressed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -43 lines) Patch
M Source/devtools/front_end/elements/ElementsPanel.js View 5 chunks +9 lines, -20 lines 0 comments Download
M Source/devtools/front_end/elements/ElementsTreeOutline.js View 1 7 chunks +6 lines, -23 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
pfeldman
6 years, 2 months ago (2014-09-24 15:57:10 UTC) #2
sergeyv
lgtm with nits https://codereview.chromium.org/603643002/diff/1/Source/devtools/front_end/elements/ElementsPanel.js File Source/devtools/front_end/elements/ElementsPanel.js (right): https://codereview.chromium.org/603643002/diff/1/Source/devtools/front_end/elements/ElementsPanel.js#newcode1287 Source/devtools/front_end/elements/ElementsPanel.js:1287: extra line https://codereview.chromium.org/603643002/diff/1/Source/devtools/front_end/elements/ElementsTreeOutline.js File Source/devtools/front_end/elements/ElementsTreeOutline.js (right): ...
6 years, 2 months ago (2014-09-24 16:17:30 UTC) #3
pfeldman
https://codereview.chromium.org/603643002/diff/1/Source/devtools/front_end/elements/ElementsPanel.js File Source/devtools/front_end/elements/ElementsPanel.js (right): https://codereview.chromium.org/603643002/diff/1/Source/devtools/front_end/elements/ElementsPanel.js#newcode1287 Source/devtools/front_end/elements/ElementsPanel.js:1287: On 2014/09/24 16:17:29, sergeyv wrote: > extra line Acknowledged. ...
6 years, 2 months ago (2014-09-24 16:23:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603643002/20001
6 years, 2 months ago (2014-09-24 16:25:54 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-24 17:41:31 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 182620

Powered by Google App Engine
This is Rietveld 408576698