Rename PromisesPanel to PromisePane.

Rename PromisesPanel to PromisePane.

BUG=348919
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184365

[Alexandra Mikhaylova, 2014-09-24 14:47:55]

amikhaylova@google.com changed reviewers:
+ aandrey@chromium.org

[aandrey, 2014-09-24 14:51:39]

lgtm

https://codereview.chromium.org/603623002/diff/1/Source/devtools/front_end/pr...
File Source/devtools/front_end/promises/PromisePane.js (right):

https://codereview.chromium.org/603623002/diff/1/Source/devtools/front_end/pr...
Source/devtools/front_end/promises/PromisePane.js:16:
buttonsBar.classList.add("promise-tracker-controls");
var buttonsBar = this.element.createChild("div", "promise-tracker-controls");

[Alexandra Mikhaylova, 2014-09-24 15:20:46]

https://codereview.chromium.org/603623002/diff/1/Source/devtools/front_end/pr...
File Source/devtools/front_end/promises/PromisePane.js (right):

https://codereview.chromium.org/603623002/diff/1/Source/devtools/front_end/pr...
Source/devtools/front_end/promises/PromisePane.js:16:
buttonsBar.classList.add("promise-tracker-controls");
On 2014/09/24 14:51:39, aandrey wrote:
> var buttonsBar = this.element.createChild("div", "promise-tracker-controls");

Done.

[Alexandra Mikhaylova, 2014-09-25 14:52:01]

amikhaylova@google.com changed reviewers:
+ apavlov@chromium.org

[Alexandra Mikhaylova, 2014-09-25 14:53:13]

On 2014/09/24 15:20:46, Alexandra Mikhaylova wrote:
>
https://codereview.chromium.org/603623002/diff/1/Source/devtools/front_end/pr...
> File Source/devtools/front_end/promises/PromisePane.js (right):
> 
>
https://codereview.chromium.org/603623002/diff/1/Source/devtools/front_end/pr...
> Source/devtools/front_end/promises/PromisePane.js:16:
> buttonsBar.classList.add("promise-tracker-controls");
> On 2014/09/24 14:51:39, aandrey wrote:
> > var buttonsBar = this.element.createChild("div",
"promise-tracker-controls");
> 
> Done.

@apavlov, we need your stamp on devtools.gypi

[aandrey, 2014-10-24 11:44:11]

ping?

[vsevik, 2014-10-24 11:49:30]

vsevik@chromium.org changed reviewers:
+ vsevik@chromium.org

[vsevik, 2014-10-24 11:49:31]

rs lgtm

[vsevik, 2014-10-24 11:49:36]

The CQ bit was checked by vsevik@chromium.org

[commit-bot: I haz the power, 2014-10-24 11:50:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/603623002/20001

[commit-bot: I haz the power, 2014-10-24 11:51:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-24 11:51:05]

Failed to apply patch for Source/devtools/front_end/promises/PromisePane.js:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  A         Source/devtools/front_end/promises/PromisePane.js
  Copied Source/devtools/front_end/promises/PromisesPanel.js ->
Source/devtools/front_end/promises/PromisePane.js
  patching file Source/devtools/front_end/promises/PromisePane.js
  Hunk #1 FAILED at 6.
  Hunk #2 FAILED at 39.
  Hunk #3 succeeded at 97 (offset 8 lines).
  2 out of 3 hunks FAILED -- saving rejects to file
Source/devtools/front_end/promises/PromisePane.js.rej

Patch:   NR 
Source/devtools/front_end/promises/PromisesPanel.js->Source/devtools/front_end/promises/PromisePane.js
Index: Source/devtools/front_end/promises/PromisePane.js
diff --git a/Source/devtools/front_end/promises/PromisesPanel.js
b/Source/devtools/front_end/promises/PromisePane.js
similarity index 94%
rename from Source/devtools/front_end/promises/PromisesPanel.js
rename to Source/devtools/front_end/promises/PromisePane.js
index
4a5af11d5c90140b37fb4d5a7c8bc0f3aac36335..3d272e18d52397626926049eaa6d95bac709b654
100644
--- a/Source/devtools/front_end/promises/PromisesPanel.js
+++ b/Source/devtools/front_end/promises/PromisePane.js
@@ -6,13 +6,13 @@
  * @constructor
  * @extends {WebInspector.VBox}
  */
-WebInspector.PromisesPanel = function()
+WebInspector.PromisePane = function()
 {
     WebInspector.VBox.call(this);
-    this.registerRequiredCSS("promisesPanel.css");
+    this.registerRequiredCSS("promisePane.css");
     this.element.classList.add("promises");
 
-    var buttonsBar = this.element.createChild("div");
+    var buttonsBar = this.element.createChild("div",
"promise-tracker-controls");
     var enableButton = buttonsBar.createChild("button");
     enableButton.textContent = WebInspector.UIString("Enable Promises
tracking");
     enableButton.addEventListener("click",
this._enableButtonClicked.bind(this));
@@ -39,7 +39,7 @@ WebInspector.PromisesPanel = function()
     this._linkifier = new WebInspector.Linkifier();
 }
 
-WebInspector.PromisesPanel.prototype = {
+WebInspector.PromisePane.prototype = {
     _refreshButtonClicked: function(event)
     {
         this._updateData();
@@ -89,7 +89,7 @@ WebInspector.PromisesPanel.prototype = {
         /**
          * @param {?Protocol.Error} error
          * @param {?Array.<!DebuggerAgent.PromiseDetails>} promiseData
-         * @this {WebInspector.PromisesPanel}
+         * @this {WebInspector.PromisePane}
          */
         function callback(error, promiseData)
         {

[Alexandra Mikhaylova, 2014-10-24 14:16:37]

On 2014/10/24 11:51:05, I haz the power (commit-bot) wrote:
> Failed to apply patch for Source/devtools/front_end/promises/PromisePane.js:
> While running patch -p1 --forward --force --no-backup-if-mismatch;
>   A         Source/devtools/front_end/promises/PromisePane.js
>   Copied Source/devtools/front_end/promises/PromisesPanel.js ->
> Source/devtools/front_end/promises/PromisePane.js
>   patching file Source/devtools/front_end/promises/PromisePane.js
>   Hunk #1 FAILED at 6.
>   Hunk #2 FAILED at 39.
>   Hunk #3 succeeded at 97 (offset 8 lines).
>   2 out of 3 hunks FAILED -- saving rejects to file
> Source/devtools/front_end/promises/PromisePane.js.rej
> 
> Patch:   NR 
>
Source/devtools/front_end/promises/PromisesPanel.js->Source/devtools/front_end/promises/PromisePane.js
> Index: Source/devtools/front_end/promises/PromisePane.js
> diff --git a/Source/devtools/front_end/promises/PromisesPanel.js
> b/Source/devtools/front_end/promises/PromisePane.js
> similarity index 94%
> rename from Source/devtools/front_end/promises/PromisesPanel.js
> rename to Source/devtools/front_end/promises/PromisePane.js
> index
>
4a5af11d5c90140b37fb4d5a7c8bc0f3aac36335..3d272e18d52397626926049eaa6d95bac709b654
> 100644
> --- a/Source/devtools/front_end/promises/PromisesPanel.js
> +++ b/Source/devtools/front_end/promises/PromisePane.js
> @@ -6,13 +6,13 @@
>   * @constructor
>   * @extends {WebInspector.VBox}
>   */
> -WebInspector.PromisesPanel = function()
> +WebInspector.PromisePane = function()
>  {
>      WebInspector.VBox.call(this);
> -    this.registerRequiredCSS("promisesPanel.css");
> +    this.registerRequiredCSS("promisePane.css");
>      this.element.classList.add("promises");
>  
> -    var buttonsBar = this.element.createChild("div");
> +    var buttonsBar = this.element.createChild("div",
> "promise-tracker-controls");
>      var enableButton = buttonsBar.createChild("button");
>      enableButton.textContent = WebInspector.UIString("Enable Promises
> tracking");
>      enableButton.addEventListener("click",
> this._enableButtonClicked.bind(this));
> @@ -39,7 +39,7 @@ WebInspector.PromisesPanel = function()
>      this._linkifier = new WebInspector.Linkifier();
>  }
>  
> -WebInspector.PromisesPanel.prototype = {
> +WebInspector.PromisePane.prototype = {
>      _refreshButtonClicked: function(event)
>      {
>          this._updateData();
> @@ -89,7 +89,7 @@ WebInspector.PromisesPanel.prototype = {
>          /**
>           * @param {?Protocol.Error} error
>           * @param {?Array.<!DebuggerAgent.PromiseDetails>} promiseData
> -         * @this {WebInspector.PromisesPanel}
> +         * @this {WebInspector.PromisePane}
>           */
>          function callback(error, promiseData)
>          {

Rebased.

[Alexandra Mikhaylova, 2014-10-24 14:16:44]

The CQ bit was checked by amikhaylova@google.com

[commit-bot: I haz the power, 2014-10-24 14:17:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/603623002/40001

[commit-bot: I haz the power, 2014-10-24 15:49:49]

Committed patchset #3 (id:40001) as 184365