Do not call run_webkit_tests.py in android buildbot scripts.

Do not call run_webkit_tests.py in android buildbot scripts.

Replace its usage by lint-test-expectations and run-webkit-tests, both
scripts found in third_party/WebKit/Tools/Scripts.

BUG=338338
TEST=None
R=dpranke@chromium.org,cmp@chromium.org

Committed: https://crrev.com/9c330bf94b161a4a19b1bcccb33b169843b4fd10
Cr-Commit-Position: refs/heads/master@{#296883}

[tfarina, 2014-09-24 13:24:21]

+dpranke, he has been reviewing these patch series.
+cmp -> build/android/buildbot owner

regards,

[Dirk Pranke, 2014-09-24 16:21:23]

lgtm

[cmp, 2014-09-24 18:14:02]

https://codereview.chromium.org/603563002/diff/1/build/android/buildbot/bb_de...
File build/android/buildbot/bb_device_steps.py (right):

https://codereview.chromium.org/603563002/diff/1/build/android/buildbot/bb_de...
build/android/buildbot/bb_device_steps.py:328:
SrcPath('third_party/WebKit/Tools/Scripts/run-webkit-tests')] + cmd_args)
+2 space indent here

but it's strange to break on the [ and start the new line on SrcPath

This is preferred:
  exit_code = RunCmd(
      [SrcPath('third_party/WebKit/Tools/Scripts/run-webkit-tests')] +
      cmd_args)

But that looks awful, too. :)

Even better would be to store "third_party/WebKit/Tools/Scripts" in a
BK_SCRIPTS_DIR constant, and use it in place, then all of this can be on one
line.  And then reuse BK_SCRIPTS_DIR on line 289.  Maybe it can all be on one
line in that case?

[tfarina, 2014-09-25 04:04:08]

Done. PTAL.

[cmp, 2014-09-25 15:56:17]

lgtm

[tfarina, 2014-09-26 03:41:38]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-09-26 03:42:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/603563002/20001

[commit-bot: I haz the power, 2014-09-26 04:26:50]

Committed patchset #2 (id:20001) as d3850b391382f8b8925f055766de9b5033cf3115

[commit-bot: I haz the power, 2014-09-26 04:27:25]

Patchset 2 (id:??) landed as
https://crrev.com/9c330bf94b161a4a19b1bcccb33b169843b4fd10
Cr-Commit-Position: refs/heads/master@{#296883}

[Mads Ager (chromium), 2014-09-26 05:44:37]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/609713002/ by ager@chromium.org.

The reason for reverting is: Makes the webkit_lint step fail on android bots:

@@@BUILD_STEP webkit_lint@@@
>
/b/build/slave/WebKit_Android__Nexus4_/build/src/third_party/WebKit/Tools/Scripts/lint-test-expectations
--target Release
Usage: lint-test-expectations [options]

lint-test-expectations: error: no such option: --target
<
/b/build/slave/WebKit_Android__Nexus4_/build/src/third_party/WebKit/Tools/Scripts/lint-test-expectations
--target Release
ERROR: process exited with code 2
@@@STEP_FAILURE@@@
.

[Dirk Pranke, 2014-09-26 20:43:37]

For the record, I've uploaded what should be the "correct" fix in
https://codereview.chromium.org/605383002/. I'll keep an eye on the bots to make
sure things work.