[turbofan] more verification of rpo

src/compiler/scheduler.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <deque>
 #include <queue>
 
 #include "src/compiler/scheduler.h"
 
 #include "src/compiler/graph.h"
@@ skipping 847 matching lines @@
     PrintF("\n");
   }
 }
 
 
 static void VerifySpecialRPO(int num_loops, LoopInfo* loops,
                              BasicBlockVector* order) {
   DCHECK(order->size() > 0);
   DCHECK((*order)[0]->id() == 0);  // entry should be first.
 
+  // All predecessors and successors should be in rpo.
+  for (BasicBlockVector::iterator i = order->begin(); i != order->end(); ++i) {
+    BasicBlock* block = *i;
+    BasicBlock::Predecessors p = block->predecessors();
+    for (BasicBlock::Predecessors::iterator j = p.begin(); j != p.end(); ++j) {
+      DCHECK((*j)->rpo_number_ >= 0);
+    }
+    BasicBlock::Successors s = block->successors();
+    for (BasicBlock::Successors::iterator j = s.begin(); j != s.end(); ++j) {
+      DCHECK((*j)->rpo_number_ >= 0);
+    }
+  }

[titzer, 2014/09/25 14:52:58]

Can we put this new code into ScheduleVerifier::Run()?

[dcarney, 2014/09/29 13:29:54]

Done.

+
   for (int i = 0; i < num_loops; i++) {
     LoopInfo* loop = &loops[i];
     BasicBlock* header = loop->header;
 
     DCHECK(header != NULL);
     DCHECK(header->rpo_number_ >= 0);
     DCHECK(header->rpo_number_ < static_cast<int>(order->size()));
     DCHECK(header->loop_end_ >= 0);
     DCHECK(header->loop_end_ <= static_cast<int>(order->size()));
     DCHECK(header->loop_end_ > header->rpo_number_);
@@ skipping 238 matching lines @@
 
 #if DEBUG
   if (FLAG_trace_turbo_scheduler) PrintRPO(num_loops, loops, final_order);
   VerifySpecialRPO(num_loops, loops, final_order);
 #endif
   return final_order;
 }
 }
 }
 }  // namespace v8::internal::compiler