Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: samples/third_party/todomvc/test/markdone_test.dart

Issue 60353013: Update TodoMVC based on https://github.com/polymer/todomvc (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: fix pubspecs Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: samples/third_party/todomvc/test/markdone_test.dart
diff --git a/samples/third_party/todomvc/test/markdone_test.dart b/samples/third_party/todomvc/test/markdone_test.dart
index e84dc71c22f8619132fbd6911b291704adca4b5d..8deaf413ae1c483fde4a90339b23d9f32dfc5993 100644
--- a/samples/third_party/todomvc/test/markdone_test.dart
+++ b/samples/third_party/todomvc/test/markdone_test.dart
@@ -9,7 +9,8 @@ import 'dart:html';
import 'package:polymer/polymer.dart';
import 'package:unittest/unittest.dart';
import 'package:unittest/html_config.dart';
-import '../web/model.dart';
+import '../web/elements/td_model.dart';
+import 'utils.dart';
Node findWithText(Node node, String text) {
if (node.text == text) return node;
@@ -27,22 +28,6 @@ Node findWithText(Node node, String text) {
return null;
}
-Node findShadowHost(Node node, ShadowRoot root) {
- if (node is Element) {
- var shadowRoot = (node as Element).shadowRoot;
- if (shadowRoot == root) return node;
- if (shadowRoot != null) {
- var r = findShadowHost(shadowRoot, root);
- if (r != null) return r;
- }
- }
- for (var n in node.nodes) {
- var r = findShadowHost(n, root);
- if (r != null) return r;
- }
- return null;
-}
-
/**
* This test runs the TodoMVC app, adds a few todos, marks some as done
* programatically, and clicks on a checkbox to mark others via the UI.
@@ -51,13 +36,19 @@ main() {
initPolymer();
useHtmlConfiguration();
- setUp(() => Polymer.onReady);
+ TodoModel model;
+
+ setUp(() => Polymer.onReady.then((_) {
+ model = query('td-model');
+ return onPropertyInit(model, 'items');
+ }));
test('mark done', () {
- appModel.todos.add(new Todo('one (unchecked)'));
- appModel.todos.add(new Todo('two (unchecked)'));
- appModel.todos.add(new Todo('three (checked)')..done = true);
- appModel.todos.add(new Todo('four (checked)'));
+ model.items
+ ..add(new Todo('one (unchecked)'))
+ ..add(new Todo('two (unchecked)'))
+ ..add(new Todo('three (checked)')..completed = true)
+ ..add(new Todo('four (checked)'));
return new Future(() {
var body = query('body');
@@ -65,8 +56,8 @@ main() {
var label = findWithText(body, 'four (checked)');
expect(label is LabelElement, true, reason: 'text is in a label: $label');
- var host = findShadowHost(body, label.parentNode);
- var node = host.parent.query('input');
+ ShadowRoot host = label.parentNode.parentNode;
+ var node = host.querySelector('input');
expect(node is InputElement, true, reason: 'node is a checkbox');
expect(node.type, 'checkbox', reason: 'node type is checkbox');
expect(node.checked, isFalse, reason: 'element is unchecked');

Powered by Google App Engine
This is Rietveld 408576698