chrome/browser/extensions/api/commands/command_service.cc - Issue 60353008: Mac global keybindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/commands/command_service.cc

Issue 60353008: Mac global keybindings (Closed) Base URL: https://src.chromium.org/chrome/trunk/src/

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: chrome/browser/extensions/api/commands/command_service.cc

===================================================================

--- chrome/browser/extensions/api/commands/command_service.cc (revision 239014)

+++ chrome/browser/extensions/api/commands/command_service.cc (working copy)

@@ -79,10 +79,17 @@

}

bool IsWhitelistedGlobalShortcut(const extensions::Command& command) {

+ // Non-global shortcuts are always allowed.

if (!command.global())

return true;

+ // Global shortcuts must be (Ctrl|Command)-Shift-[0-9].

+#if defined OS_MACOSX

+ if (!command.accelerator().IsCmdDown())

+ return false;

+#else

if (!command.accelerator().IsCtrlDown())

return false;

+#endif

if (!command.accelerator().IsShiftDown())

return false;

return (command.accelerator().key_code() >= ui::VKEY_0 &&