Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 603503003: Always force the bounds of the empty pathref. (Closed)

Created:
6 years, 2 months ago by mtklein_C
Modified:
6 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Always force the bounds of the empty pathref. Chrome's TSAN bots are seeing various races on the bounds of the empty path ref, and it's a simple fix to just force them on creation. In fact, we used to do this for this very reason, but for some reason it looks like I decided it wasn't necessary. Maybe not, but it certainly doesn't hurt, and it's nice to keep TSAN happy. Reminder to self: merge this into M39 branch too. BUG=418299 Committed: https://skia.googlesource.com/skia/+/51936a3f07d18654be966527691067729c070bd3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/core/SkPathRef.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 14 (4 generated)
mtklein
First reviewer wins!
6 years, 2 months ago (2014-09-27 15:13:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603503003/1
6 years, 2 months ago (2014-09-27 15:14:24 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-09-27 15:14:25 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-09-27 17:19:14 UTC) #6
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-09-27 18:03:12 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
6 years, 2 months ago (2014-09-28 00:03:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603503003/1
6 years, 2 months ago (2014-09-29 12:25:40 UTC) #11
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-09-29 12:25:41 UTC) #12
robertphillips
lgtm
6 years, 2 months ago (2014-09-29 12:26:09 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 12:28:02 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 51936a3f07d18654be966527691067729c070bd3

Powered by Google App Engine
This is Rietveld 408576698