|
|
Don't add '(' to FUNCTION token names
This patch makes our bison tokenizer parse FUNCTION tokens without the
opening parenthesis. This makes FUNCTIONs with escapes work correctly,
tested in color3.html.
This will be followed up with using CSSValueID for all the strings in
the CSSPropertyParser for Function types. This will provide consistency
with regular keywords, and allow us to remove the code generation in
parsing transforms. In css3-syntax, a function token's value doesn't
include the bracket.
We also change the stored value of pseudo-selectors with arguments to
not include the bracket. This makes no difference since in these cases
we never read the value aside from to parse or serialize it.
BUG= 411165
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182677
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+126 lines, -112 lines) |
Patch |
 |
M |
LayoutTests/css-parser/color3-expected.txt
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
Source/core/css/CSSCalculationValue.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
Source/core/css/CSSComputedStyleDeclaration.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
Source/core/css/CSSSelector.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
Source/core/css/CSSSelector.cpp
|
View
|
|
10 chunks |
+32 lines, -17 lines |
0 comments
|
Download
|
 |
M |
Source/core/css/parser/BisonCSSParser-in.cpp
|
View
|
|
2 chunks |
+22 lines, -22 lines |
0 comments
|
Download
|
 |
M |
Source/core/css/parser/CSSPropertyParser.cpp
|
View
|
|
23 chunks |
+64 lines, -64 lines |
0 comments
|
Download
|
 |
M |
Source/core/css/parser/CSSTokenizer-in.cpp
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
Source/core/dom/Element.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
Source/core/frame/LocalDOMWindow.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
Total messages: 6 (2 generated)
|