Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 603443002: Don't add '(' to FUNCTION token names (Closed)

Created:
6 years, 2 months ago by Timothy Loh
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-css, sof, eae+blinkwatch, ed+blinkwatch_opera.com, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@internalsetshadowunused
Project:
blink
Visibility:
Public.

Description

Don't add '(' to FUNCTION token names This patch makes our bison tokenizer parse FUNCTION tokens without the opening parenthesis. This makes FUNCTIONs with escapes work correctly, tested in color3.html. This will be followed up with using CSSValueID for all the strings in the CSSPropertyParser for Function types. This will provide consistency with regular keywords, and allow us to remove the code generation in parsing transforms. In css3-syntax, a function token's value doesn't include the bracket. We also change the stored value of pseudo-selectors with arguments to not include the bracket. This makes no difference since in these cases we never read the value aside from to parse or serialize it. BUG=411165 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182677

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -112 lines) Patch
M LayoutTests/css-parser/color3-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSCalculationValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSSelector.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSSelector.cpp View 10 chunks +32 lines, -17 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 2 chunks +22 lines, -22 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 23 chunks +64 lines, -64 lines 0 comments Download
M Source/core/css/parser/CSSTokenizer-in.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/LocalDOMWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Timothy Loh
6 years, 2 months ago (2014-09-24 08:01:29 UTC) #2
alancutter (OOO until 2018)
lgtm
6 years, 2 months ago (2014-09-25 08:36:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603443002/1
6 years, 2 months ago (2014-09-25 11:09:39 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 12:58:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182677

Powered by Google App Engine
This is Rietveld 408576698