Issue 60343003: [NaCl SDK] Check for valid CONFIG parameter to Makefile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 60343003: [NaCl SDK] Check for valid CONFIG parameter to Makefile. (Closed)

Created:
7 years, 1 month ago by binji

Modified:
7 years, 1 month ago

Reviewers:
Sam Clegg

CC:
chromium-reviews, Sam Clegg

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[NaCl SDK] Check for valid CONFIG parameter to Makefile. This just burned me when I typed "make CONFIG=Relase" and the build system happily created a directory tree with "pnacl/Relase" in it. BUG=none R=sbc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233146

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	native_client_sdk/src/tools/common.mk	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

binji

7 years, 1 month ago (2013-11-06 00:02:12 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r233146 (presubmit successful).