Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 603423002: Replace OVERRIDE and FINAL with their C++11 counterparts in core/accessibility (Closed)

Created:
6 years, 2 months ago by Mikhail
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, shans, kouhei+svg_chromium.org, tzik, webcomponents-bugzilla_chromium.org, eae+blinkwatch, fs, dcheng, yurys+blink_chromium.org, zoltan1, nessy, apavlov+blink_chromium.org, falken, Inactive, kinuko+worker_chromium.org, loislo+blink_chromium.org, Steve Block, lushnikov+blink_chromium.org, Stephen Chennney, rune+blink, blink-layers+watch_chromium.org, Yoav Weiss, aandrey+blink_chromium.org, aboxhall, blink-reviews-events_chromium.org, malch+blink_chromium.org, blink-reviews-css, blink-reviews-html_chromium.org, Timothy Loh, abarth-chromium, dstockwell, dglazkov+blink, Rik, gavinp+loader_chromium.org, jchaffraix+rendering, devtools-reviews_chromium.org, rwlbuis, pdr+svgwatchlist_chromium.org, Eric Willigers, kenneth.christiansen, jfernandez, philipj_slow, rjwright, mvanouwerkerk+watch_chromium.org, Manuel Rego, sof, caseq+blink_chromium.org, nhiroki, pfeldman+blink_chromium.org, feature-media-reviews_chromium.org, dmazzoni, timvolodine, darktears, krit, Nate Chapin, vcarbune.chromium, cbiesinger, blink-reviews-rendering, gavinp+prerender_chromium.org, chromiumbugtracker_adobe.com, eustas+blink_chromium.org, blink-reviews-animation_chromium.org, eric.carlson_apple.com, pdr+renderingwatchlist_chromium.org, gasubic, leviw+renderwatch, vsevik+blink_chromium.org, Mike Lawther (Google), ed+blinkwatch_opera.com, paulirish+reviews_chromium.org, f(malita), groby+blinkspell_chromium.org, svillar, horo+watch_chromium.org, sergeyv+blink_chromium.org, kinuko+fileapi, gyuyoung.kim_webkit.org, Avi (use Gerrit), Nico, eseidel
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Replace OVERRIDE and FINAL with their C++11 counterparts in core A search and replace for OVERRIDE and FINAL to replace them with their lowercase versions in Blink core/accessibility. BUG=417463 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183182

Patch Set 1 #

Patch Set 2 : Narrowing area to core/accessibility #

Unified diffs Side-by-side diffs Delta from patch set Stats (+354 lines, -354 lines) Patch
M Source/core/accessibility/AXARIAGrid.h View 1 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/accessibility/AXARIAGridCell.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/accessibility/AXARIAGridRow.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/accessibility/AXImageMapLink.h View 1 2 chunks +15 lines, -15 lines 0 comments Download
M Source/core/accessibility/AXInlineTextBox.h View 1 2 chunks +11 lines, -11 lines 0 comments Download
M Source/core/accessibility/AXList.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/accessibility/AXListBox.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/accessibility/AXListBoxOption.h View 1 2 chunks +12 lines, -12 lines 0 comments Download
M Source/core/accessibility/AXMediaControls.h View 1 2 chunks +18 lines, -18 lines 0 comments Download
M Source/core/accessibility/AXMenuList.h View 1 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/accessibility/AXMenuListOption.h View 1 2 chunks +14 lines, -14 lines 0 comments Download
M Source/core/accessibility/AXMenuListPopup.h View 1 1 chunk +11 lines, -11 lines 0 comments Download
M Source/core/accessibility/AXMockObject.h View 1 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/accessibility/AXNodeObject.h View 1 2 chunks +70 lines, -70 lines 0 comments Download
M Source/core/accessibility/AXProgressIndicator.h View 1 1 chunk +7 lines, -7 lines 0 comments Download
M Source/core/accessibility/AXRenderObject.h View 1 2 chunks +77 lines, -77 lines 0 comments Download
M Source/core/accessibility/AXSVGRoot.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/accessibility/AXScrollView.h View 1 1 chunk +21 lines, -21 lines 0 comments Download
M Source/core/accessibility/AXScrollbar.h View 1 2 chunks +11 lines, -11 lines 0 comments Download
M Source/core/accessibility/AXSlider.h View 1 1 chunk +12 lines, -12 lines 0 comments Download
M Source/core/accessibility/AXSpinButton.h View 1 3 chunks +11 lines, -11 lines 0 comments Download
M Source/core/accessibility/AXTable.h View 1 3 chunks +8 lines, -8 lines 0 comments Download
M Source/core/accessibility/AXTableCell.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/accessibility/AXTableColumn.h View 1 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/accessibility/AXTableHeaderContainer.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/accessibility/AXTableRow.h View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Mikhail
PTAL
6 years, 2 months ago (2014-09-26 09:06:10 UTC) #1
Stephen Chennney
Could you please include the regex you used to do the substitution? This would be ...
6 years, 2 months ago (2014-09-26 19:10:31 UTC) #3
Mikhail
On 2014/09/26 19:10:31, Stephen Chenney wrote: > Could you please include the regex you used ...
6 years, 2 months ago (2014-10-02 11:01:39 UTC) #4
dmazzoni
lgtm for core/accessibility
6 years, 2 months ago (2014-10-02 15:04:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603423002/10001
6 years, 2 months ago (2014-10-03 08:02:42 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-03 09:06:52 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:10001) as 183182

Powered by Google App Engine
This is Rietveld 408576698