Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 603413003: Correct condition and flag state for skipping PLAY request. (Closed)

Created:
6 years, 2 months ago by fukino
Modified:
6 years, 2 months ago
Reviewers:
mtomasz, yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Correct condition and flag state for skipping PLAY request. * When PLAY request for casted video is skipped, this.playInProgress_ was not cleared and this inconsistent state prevented the video from being played. I cleared the flag in this case. * When PAUSE reqeust is in progress, incoming PLAY request should not be skipped. So I added a condition to skip the PLAY request. BUG=417520, 417538 TEST=manually tested the steps described in both bugs. Committed: https://crrev.com/af8a4054eab230950711b506c096a69b5ed162e4 Cr-Commit-Position: refs/heads/master@{#297137}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M ui/file_manager/video_player/js/cast/cast_video_element.js View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
fukino
Tomasz, PTAL the CL? Thanks!
6 years, 2 months ago (2014-09-26 09:02:16 UTC) #2
mtomasz
lgtm
6 years, 2 months ago (2014-09-29 00:25:05 UTC) #3
fukino
Thanks Tomasz! @yoshiki, could you take a look, too?
6 years, 2 months ago (2014-09-29 03:21:55 UTC) #5
yoshiki
lgtm thanks!
6 years, 2 months ago (2014-09-29 03:48:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603413003/1
6 years, 2 months ago (2014-09-29 03:48:47 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 943b2680a1a3ebf2e5a9a5b6faccbea8c89685cd
6 years, 2 months ago (2014-09-29 04:34:09 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 04:36:05 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af8a4054eab230950711b506c096a69b5ed162e4
Cr-Commit-Position: refs/heads/master@{#297137}

Powered by Google App Engine
This is Rietveld 408576698