Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1844)

Issue 603413002: Revert of Start building ui_base_unittests targets. (Closed)

Created:
6 years, 2 months ago by perkj_chrome
Modified:
6 years, 2 months ago
CC:
chromium-reviews, kalyank, klundberg+watch_chromium.org, sadrul, yfriedman+watch_chromium.org, ben+ash_chromium.org, bulach
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Start building ui_base_unittests targets. (patchset #1 id:1 of https://codereview.chromium.org/600833002/) Reason for revert: Breaks Android waterfall. http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29 Original issue's description: > Start building ui_base_unittests targets. > > This is in preparation for updating the buildbot code. First we need to > make sure we build those targets, otherwise buildbot will fail. > > BUG=331829, 373148, 299841, 103304 > TEST=None > R=sky@chromium.org,maruel@chromium.org > > Committed: https://crrev.com/430fc906824927713d5a318afb50654e95b699b0 > Cr-Commit-Position: refs/heads/master@{#296877} TBR=cjhopman@chromium.org,sky@chromium.org,maruel@chromium.org,tfarina@chromium.org NOTREECHECKS=true NOTRY=true BUG=331829, 373148, 299841, 103304 Committed: https://crrev.com/79c886b2fa50d0634d8d8a84903f9a9ea96f5471 Cr-Commit-Position: refs/heads/master@{#296903}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -15 lines) Patch
M PRESUBMIT.py View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/ash_native_cursor_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M build/all.gyp View 10 chunks +0 lines, -10 lines 0 comments Download
M build/android/pylib/gtest/gtest_config.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/pylib/gtest/setup.py View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (1 generated)
perkj_chrome
Created Revert of Start building ui_base_unittests targets.
6 years, 2 months ago (2014-09-26 07:32:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603413002/1
6 years, 2 months ago (2014-09-26 07:32:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 596a758d1ddb2c667a2e8a9ac89db9c6158fbc20
6 years, 2 months ago (2014-09-26 07:33:12 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/79c886b2fa50d0634d8d8a84903f9a9ea96f5471 Cr-Commit-Position: refs/heads/master@{#296903}
6 years, 2 months ago (2014-09-26 07:33:52 UTC) #4
tfarina
Primiano, any idea how this is possible? [ERROR:platform_font_android.cc(13)] Not implemented reached in static gfx::PlatformFont* gfx::PlatformFont::CreateDefault() ...
6 years, 2 months ago (2014-09-26 14:14:45 UTC) #6
Primiano Tucci (use gerrit)
On 2014/09/26 14:14:45, tfarina wrote: > Primiano, any idea how this is possible? > > ...
6 years, 2 months ago (2014-09-26 14:36:52 UTC) #7
tfarina
Aha! Thanks for the investigation Primiano! Got it! ResourceBundleTest.DelegateGetFontList is disabled for ui_unittests by: https://code.google.com/p/chromium/codesearch#chromium/src/build/android/pylib/gtest/filter/ui_unittests_disabled&l=1&q=DelegateGetFontList%20&type=cs&sq=package:chromium ...
6 years, 2 months ago (2014-09-26 15:47:44 UTC) #8
tfarina
6 years, 2 months ago (2014-09-26 19:35:40 UTC) #9
Message was sent while issue was closed.
I have uploaded a CL to fix this -> https://codereview.chromium.org/611513003/

Powered by Google App Engine
This is Rietveld 408576698