Issue 603383002: Revert "Revert of HTMLSelectElement does not include selected index/indices while saving state (pat…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 603383002: Revert "Revert of HTMLSelectElement does not include selected index/indices while saving state (pat… (Closed)

Created:
6 years, 2 months ago by spartha

Modified:
6 years, 2 months ago

Reviewers:
tkent, keishi

CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Revert "Revert of HTMLSelectElement does not include selected index/indices while saving state (patchset #8 id:160001 of https://codereview.chromium.org/541693003/)" Reason for revert: The actual cause of the test failure was the lack of support for localized strings in test framework for <select>. That was fixed with https://codereview.chromium.org/593113003/ BUG=401506 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182741

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+132 lines, -12 lines)			Patch
M	Source/core/core.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/html/HTMLSelectElement.cpp	View	2 chunks	+25 lines, -11 lines	0 comments	Download
A	Source/core/html/HTMLSelectElementTest.cpp	View	1 chunk	+105 lines, -0 lines	0 comments	Download
M	Source/core/html/forms/FormController.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (2 generated)

spartha

Restoring https://codereview.chromium.org/541693003/ PTAL!

6 years, 2 months ago (2014-09-26 06:52:29 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603383002/1

6 years, 2 months ago (2014-09-26 07:52:51 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-09-26 08:30:41 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 182741