Files.app: Always do fallback guessing mime type from file extensions when obtaining empty metadata…

Files.app: Always do fallback guessing mime type from file extensions when obtaining empty metadata from the backend.

BUG=417978
TEST=Open files by using externalfile: scheme that runs the related code path.

Committed: https://crrev.com/d090da9418e12e954b99afd307ac6c1d26d1184d
Cr-Commit-Position: refs/heads/master@{#296911}

[hirono, 2014-09-26 04:31:10]

hirono@chromium.org changed reviewers:
+ mtomasz@chromium.org

[hirono, 2014-09-26 04:31:10]

PTAL the CL? Thank you!

[mtomasz, 2014-09-26 07:43:21]

On 2014/09/26 04:31:10, hirono wrote:
> PTAL the CL? Thank you!

Seems that the change got committed already with the previous CL?

[hirono, 2014-09-26 08:08:18]

On 2014/09/26 07:43:21, mtomasz wrote:
> On 2014/09/26 04:31:10, hirono wrote:
> > PTAL the CL? Thank you!
> 
> Seems that the change got committed already with the previous CL?

The change was not committed yet. But it looks the changes are disappear from
the latest patch set.
Let me re-upload.

[hirono, 2014-09-26 08:18:31]

Done. PTAL, thank you!

[mtomasz, 2014-09-26 08:21:00]

lgtm with a tiny nit. Thanks!

https://codereview.chromium.org/603373002/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/file_manager/filesystem_api_util.cc (right):

https://codereview.chromium.org/603373002/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/file_manager/filesystem_api_util.cc:182: // error with
empty mimetype, that leads fallback guessing mime type from file
nit: mimetype -> MIME type for consistency?

[hirono, 2014-09-26 08:33:31]

The CQ bit was checked by hirono@chromium.org

[hirono, 2014-09-26 08:33:42]

Thank you!

https://codereview.chromium.org/603373002/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/file_manager/filesystem_api_util.cc (right):

https://codereview.chromium.org/603373002/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/file_manager/filesystem_api_util.cc:182: // error with
empty mimetype, that leads fallback guessing mime type from file
On 2014/09/26 08:21:00, mtomasz wrote:
> nit: mimetype -> MIME type for consistency?

Done.

[commit-bot: I haz the power, 2014-09-26 08:34:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/603373002/60001

[commit-bot: I haz the power, 2014-09-26 09:39:14]

Committed patchset #4 (id:60001) as 5b33ab38028186ea9c4d6a00ebf06fdd003e2464

[commit-bot: I haz the power, 2014-09-26 09:39:51]

Patchset 4 (id:??) landed as
https://crrev.com/d090da9418e12e954b99afd307ac6c1d26d1184d
Cr-Commit-Position: refs/heads/master@{#296911}