DevTools: Add geolocation override in browser

content/browser/geolocation/geolocation_dispatcher_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/geolocation/geolocation_dispatcher_host.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/metrics/histogram.h"
@@ skipping 73 matching lines @@
       paused_(false),
       weak_factory_(this) {
   // This is initialized by WebContentsImpl. Do not add any non-trivial
   // initialization here, defer to OnStartUpdating which is triggered whenever
   // a javascript geolocation object is actually initialized.
 }
 
 GeolocationDispatcherHost::~GeolocationDispatcherHost() {
 }
 
+void GeolocationDispatcherHost::SetOverride(
+    scoped_ptr<Geoposition> geoposition) {
+  geoposition_override_.swap(geoposition);
+  RefreshGeolocationOptions();
+  OnLocationUpdate(*geoposition_override_);
+}
+
+void GeolocationDispatcherHost::ClearOverride() {
+  geoposition_override_.reset();
+  RefreshGeolocationOptions();
+}
+
 void GeolocationDispatcherHost::RenderFrameDeleted(
     RenderFrameHost* render_frame_host) {
   OnStopUpdating(render_frame_host);
 }
 
 void GeolocationDispatcherHost::RenderViewHostChanged(
     RenderViewHost* old_host,
     RenderViewHost* new_host) {
   updating_frames_.clear();
   paused_ = false;
@@ skipping 19 matching lines @@
 void GeolocationDispatcherHost::OnLocationUpdate(
     const Geoposition& geoposition) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   RecordGeopositionErrorCode(geoposition.error_code);
   if (paused_)
     return;
 
   for (std::map<RenderFrameHost*, bool>::iterator i = updating_frames_.begin();
        i != updating_frames_.end(); ++i) {
-    RenderFrameHost* top_frame = i->first;
-    while (top_frame->GetParent()) {
-      top_frame = top_frame->GetParent();
-    }
-    GetContentClient()->browser()->DidUseGeolocationPermission(
-        web_contents(),
-        i->first->GetLastCommittedURL().GetOrigin(),
-        top_frame->GetLastCommittedURL().GetOrigin());
-
-    i->first->Send(new GeolocationMsg_PositionUpdated(
-        i->first->GetRoutingID(), geoposition));
+    UpdateGeoposition(i->first, geoposition);
   }
 }
 
+void GeolocationDispatcherHost::UpdateGeoposition(
+    RenderFrameHost* frame,
+    const Geoposition& geoposition) {
+  RenderFrameHost* top_frame = frame;
+  while (top_frame->GetParent()) {
+    top_frame = top_frame->GetParent();
+  }
+  GetContentClient()->browser()->DidUseGeolocationPermission(
+      web_contents(),
+      frame->GetLastCommittedURL().GetOrigin(),
+      top_frame->GetLastCommittedURL().GetOrigin());
+
+  frame->Send(new GeolocationMsg_PositionUpdated(
+      frame->GetRoutingID(), geoposition));
+}
+
 void GeolocationDispatcherHost::OnRequestPermission(
     RenderFrameHost* render_frame_host,
     int bridge_id,
     const GURL& requesting_frame,
     bool user_gesture) {
   int render_process_id = render_frame_host->GetProcess()->GetID();
   int render_frame_id = render_frame_host->GetRoutingID();
 
   PendingPermission pending_permission(
       render_frame_id, render_process_id, bridge_id);
@@ skipping 33 matching lines @@
     const GURL& requesting_frame,
     bool enable_high_accuracy) {
   // StartUpdating() can be invoked as a result of high-accuracy mode
   // being enabled / disabled. No need to record the dispatcher again.
   UMA_HISTOGRAM_BOOLEAN(
       "Geolocation.GeolocationDispatcherHostImpl.EnableHighAccuracy",
       enable_high_accuracy);
 
   updating_frames_[render_frame_host] = enable_high_accuracy;
   RefreshGeolocationOptions();
+  if (geoposition_override_.get())
+    UpdateGeoposition(render_frame_host, *geoposition_override_);
 }
 
 void GeolocationDispatcherHost::OnStopUpdating(
     RenderFrameHost* render_frame_host) {
   updating_frames_.erase(render_frame_host);
   RefreshGeolocationOptions();
 }
 
 void GeolocationDispatcherHost::PauseOrResume(bool should_pause) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   paused_ = should_pause;
   RefreshGeolocationOptions();
+  if (geoposition_override_.get())

[blundell, 2014/10/21 08:44:20]

drive-by: Naively, it seems like the code at lines 232 and 233 should execute
only when |!paused_|. Is that correct? If so, no need to do a follow-up CL; I'll
take care of it when porting this flow to the Mojo impl in
https://codereview.chromium.org/628773003/.

[vkuzkokov, 2014/10/21 11:58:27]

There is a check in OnLocationUpdate. This doesn't seem ot matter for your CL
though.

[blundell, 2014/10/21 12:12:44]

Ah right, I had forgotten about that. It matters for my CL only because I wanted
to ensure that I'm correctly porting the override behavior to the Mojo impl.

+    OnLocationUpdate(*geoposition_override_);
 }
 
 void GeolocationDispatcherHost::RefreshGeolocationOptions() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
-  if (updating_frames_.empty() || paused_) {
+  if (updating_frames_.empty() || paused_ || geoposition_override_.get()) {
     geolocation_subscription_.reset();
     return;
   }
 
   bool high_accuracy = false;
   for (std::map<RenderFrameHost*, bool>::iterator i =
             updating_frames_.begin(); i != updating_frames_.end(); ++i) {
     if (i->second) {
       high_accuracy = true;
       break;
@@ skipping 29 matching lines @@
 
       pending_permissions_.erase(pending_permissions_.begin() + i);
       return;
     }
   }
 
   NOTREACHED();
 }
 
 }  // namespace content