Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 603323002: Maybe add CORS headers to data reduction proxy redirect (Closed)

Created:
6 years, 2 months ago by bengr
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Maybe add CORS headers to data reduction proxy redirect When the data reduction proxy responds with a bypass message, chromium constructs a redirect response and feeds that through the network stack. This results in the request being retried directly to the origin. If the original request had an Origin header, then the manufactured redirect should have the appropriate CORS headers. BUG=415644 Committed: https://crrev.com/e2c9516537409ac095d0def19c51710def704926 Cr-Commit-Position: refs/heads/master@{#296942}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -0 lines) Patch
M components/data_reduction_proxy/browser/data_reduction_proxy_protocol.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M components/data_reduction_proxy/browser/data_reduction_proxy_protocol_unittest.cc View 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bengr
6 years, 2 months ago (2014-09-25 23:05:07 UTC) #3
marq (ping after 24h)
lgtm
6 years, 2 months ago (2014-09-26 07:58:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603323002/20001
6 years, 2 months ago (2014-09-26 14:13:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001) as dc6809b7ca7ee59b9da7e4f9be9786e2b322935f
6 years, 2 months ago (2014-09-26 15:20:42 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 15:21:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e2c9516537409ac095d0def19c51710def704926
Cr-Commit-Position: refs/heads/master@{#296942}

Powered by Google App Engine
This is Rietveld 408576698