Fix crash when showing multiple popups.

Fix crash when showing multiple popups.

The problem is that calling hide/cancel on a popup is async.

With two popups, you would get

Previously:
SHOW A
HIDE A
SHOW B
NOTIFY SELECTION A
HIDE B
NOTIFY SELECTION B

When notifying the selection of A in the above scenario, it was
clearing the frame pointer (and actually updating the wrong popup).
Then when hiding the second popup, it's reference was actually gone
already.

Fix this by making the call to hide sync instead of async.

BUG=416354
Committed: https://crrev.com/52516a4c58a6ec6a88452601e2efea6e2f75704a
Cr-Commit-Position: refs/heads/master@{#296826}

[Ted C, 2014-09-25 21:38:01]

tedchoc@chromium.org changed reviewers:
+ avi@chromium.org, jdduke@chromium.org

[Ted C, 2014-09-25 21:38:01]

PTAL

[jdduke (slow), 2014-09-25 21:43:30]

lgtm. I don't suppose we have any existing tests for this code that could be
fleshed out further?

https://codereview.chromium.org/603303002/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDialog.java
(right):

https://codereview.chromium.org/603303002/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDialog.java:108:
private static int[] getSelectedIndices(ListView listView) {
Woo!

[Avi (use Gerrit), 2014-09-25 21:43:30]

This looks plausible but I don't know the internals well enough to say. I'm
happy to stamp with feedback from an expert.

[Avi (use Gerrit), 2014-09-25 21:44:01]

Oh, crossed paths. LGTM!

[Ted C, 2014-09-25 22:30:14]

The CQ bit was checked by tedchoc@chromium.org

[commit-bot: I haz the power, 2014-09-25 22:31:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/603303002/1

[commit-bot: I haz the power, 2014-09-25 23:24:57]

Committed patchset #1 (id:1) as 31f4041fefdf529bf9b9aa78fe7a86d4e4bb1577

[commit-bot: I haz the power, 2014-09-25 23:27:22]

Patchset 1 (id:??) landed as
https://crrev.com/52516a4c58a6ec6a88452601e2efea6e2f75704a
Cr-Commit-Position: refs/heads/master@{#296826}