Showing only chromium status on chromium page, and both on blink

Showing only chromium status on chromium page, and both on blink

BUG=405591
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183560

[fgorski, 2014-09-25 19:40:32]

fgorski@chromium.org changed reviewers:
+ ojan@chromium.org

[fgorski, 2014-10-08 20:01:40]

PTAL.

Switched to fix proposed by Travis.
Added tests.

[ojan, 2014-10-09 01:58:58]

lgtm, but I'd remove the .failures from the tests, which will also let you get
this down to just two test cases.

https://codereview.chromium.org/603293002/diff/20001/Tools/GardeningServer/ui...
File Tools/GardeningServer/ui/test/ct-unexpected-failures-tests.html (right):

https://codereview.chromium.org/603293002/diff/20001/Tools/GardeningServer/ui...
Tools/GardeningServer/ui/test/ct-unexpected-failures-tests.html:71:
hasFailures.failures = new CTFailures(new CTCommitList(undefined, []));
Why do we need the failures at all, including the tests for different failures
on different trees? The tree can be closed with no failures on any tree and we
still show the closure message.

[ojan, 2014-10-09 01:59:10]

thanks for fixing this btw!

[fgorski, 2014-10-10 20:14:59]

Setting NOTRY=true per Ojan's suggestion

https://codereview.chromium.org/603293002/diff/20001/Tools/GardeningServer/ui...
File Tools/GardeningServer/ui/test/ct-unexpected-failures-tests.html (right):

https://codereview.chromium.org/603293002/diff/20001/Tools/GardeningServer/ui...
Tools/GardeningServer/ui/test/ct-unexpected-failures-tests.html:71:
hasFailures.failures = new CTFailures(new CTCommitList(undefined, []));
On 2014/10/09 01:58:57, ojan-only-code-yellow-reviews wrote:
> Why do we need the failures at all, including the tests for different failures
> on different trees? The tree can be closed with no failures on any tree and we
> still show the closure message.

Good point, failures are only impacting visibility of the tree status not it's
presence.

[ojan, 2014-10-10 20:15:49]

The CQ bit was checked by ojan@chromium.org

[ojan, 2014-10-10 20:15:50]

lgtm

[ojan, 2014-10-10 20:16:06]

The CQ bit was unchecked by ojan@chromium.org

[fgorski, 2014-10-10 20:18:52]

The CQ bit was checked by fgorski@chromium.org

[commit-bot: I haz the power, 2014-10-10 20:20:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/603293002/100001

[commit-bot: I haz the power, 2014-10-10 21:52:10]

Committed patchset #4 (id:100001) as 183560