Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Issue 603273006: Move the casting icon to media controls. (Closed)

Created:
6 years, 2 months ago by mtomasz
Modified:
6 years, 2 months ago
Reviewers:
fukino
CC:
chromium-reviews, feature-media-reviews_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move the casting icon to media controls. This patch moves the icon from the header to media controls. TEST=Tested manually. BUG=415426 Committed: https://crrev.com/4c4ce96d75c2e59a73727a3b5ef14e08b90c823c Cr-Commit-Position: refs/heads/master@{#296905}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -65 lines) Patch
M ui/file_manager/video_player/css/header.css View 2 chunks +2 lines, -34 lines 0 comments Download
M ui/file_manager/video_player/css/media_controls.css View 6 chunks +48 lines, -19 lines 0 comments Download
D ui/file_manager/video_player/images/100/cast_off.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/100/cast_off_hover.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/100/cast_on.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/100/cast_on0.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/100/cast_on1.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/100/cast_on2.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/100/cast_on_hover.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/200/cast_off.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/200/cast_off_hover.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/200/cast_on.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/200/cast_on0.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/200/cast_on1.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/200/cast_on2.png View Binary file 0 comments Download
D ui/file_manager/video_player/images/200/cast_on_hover.png View Binary file 0 comments Download
A ui/file_manager/video_player/images/media/2x/media_chromecast.png View Binary file 0 comments Download
A ui/file_manager/video_player/images/media/2x/media_chromecast_casting.png View Binary file 0 comments Download
A ui/file_manager/video_player/images/media/2x/media_chromecast_casting_down.png View Binary file 0 comments Download
A ui/file_manager/video_player/images/media/2x/media_chromecast_casting_hover.png View Binary file 0 comments Download
A ui/file_manager/video_player/images/media/2x/media_chromecast_down.png View Binary file 0 comments Download
A ui/file_manager/video_player/images/media/2x/media_chromecast_hover.png View Binary file 0 comments Download
M ui/file_manager/video_player/images/media/2x/media_fullscreen.png View Binary file 0 comments Download
M ui/file_manager/video_player/images/media/2x/media_fullscreen_down.png View Binary file 0 comments Download
M ui/file_manager/video_player/images/media/2x/media_fullscreen_hover.png View Binary file 0 comments Download
A ui/file_manager/video_player/images/media/media_chromecast.png View Binary file 0 comments Download
A ui/file_manager/video_player/images/media/media_chromecast_casting.png View Binary file 0 comments Download
A ui/file_manager/video_player/images/media/media_chromecast_casting_down.png View Binary file 0 comments Download
A ui/file_manager/video_player/images/media/media_chromecast_casting_hover.png View Binary file 0 comments Download
A ui/file_manager/video_player/images/media/media_chromecast_down.png View Binary file 0 comments Download
A ui/file_manager/video_player/images/media/media_chromecast_hover.png View Binary file 0 comments Download
M ui/file_manager/video_player/images/media/media_fullscreen.png View Binary file 0 comments Download
M ui/file_manager/video_player/images/media/media_fullscreen_down.png View Binary file 0 comments Download
M ui/file_manager/video_player/images/media/media_fullscreen_hover.png View Binary file 0 comments Download
M ui/file_manager/video_player/js/media_controls.js View 1 chunk +7 lines, -0 lines 0 comments Download
M ui/file_manager/video_player/js/video_player.js View 1 chunk +0 lines, -9 lines 0 comments Download
M ui/file_manager/video_player/video_player.html View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mtomasz
@fukino: PTAL. Thanks!
6 years, 2 months ago (2014-09-26 07:52:27 UTC) #2
fukino
On 2014/09/26 07:52:27, mtomasz wrote: > @fukino: PTAL. Thanks! lgtm. Thank you for taking this ...
6 years, 2 months ago (2014-09-26 08:22:43 UTC) #3
mtomasz
On 2014/09/26 08:22:43, fukino wrote: > On 2014/09/26 07:52:27, mtomasz wrote: > > @fukino: PTAL. ...
6 years, 2 months ago (2014-09-26 08:23:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603273006/1
6 years, 2 months ago (2014-09-26 08:24:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as f2f1e4af82ad1e66cf458027f04bf8ae22a24966
6 years, 2 months ago (2014-09-26 08:28:35 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 08:29:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4c4ce96d75c2e59a73727a3b5ef14e08b90c823c
Cr-Commit-Position: refs/heads/master@{#296905}

Powered by Google App Engine
This is Rietveld 408576698