gpu/command_buffer/client/BUILD.gn - Issue 603273003: Prevent static mojo builds from pulling //ui/gl into mojo_shell

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/client/BUILD.gn

Issue 603273003: Prevent static mojo builds from pulling //ui/gl into mojo_shell (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Forgot to remove an extra define in gn Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_process_host_impl.cc ('k') | gpu/command_buffer/client/gles2_implementation.cc » ('j') | gpu/command_buffer/client/gpu_switches.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/client/BUILD.gn

diff --git a/gpu/command_buffer/client/BUILD.gn b/gpu/command_buffer/client/BUILD.gn

index 01a90a3a2e3bb65baa177d7b61e7e1a0ac4b2ec3..c462d3d668600c298d9ff2249fdd7a3467739b05 100644

--- a/gpu/command_buffer/client/BUILD.gn

+++ b/gpu/command_buffer/client/BUILD.gn

@@ -9,6 +9,8 @@ source_set("client") {

"fenced_allocator.cc",

"fenced_allocator.h",

"gpu_control.h",

+ "gpu_switches.cc",

+ "gpu_switches.h",

"mapped_memory.cc",

"mapped_memory.h",

"ring_buffer.cc",

@@ -109,7 +111,7 @@ source_set("gles2_interface") {

component("gles2_implementation") {

sources = gles2_implementation_source_files

- defines = [ "GLES2_IMPL_IMPLEMENTATION" ]

+ defines = ["GLES2_IMPL_IMPLEMENTATION"]

all_dependent_configs = [ "//third_party/khronos:khronos_headers" ]

if (is_win) {

@@ -123,7 +125,6 @@ component("gles2_implementation") {

"//base",

"//gpu/command_buffer/common",

"//ui/gfx/geometry",

- "//ui/gl",

]

}