Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: mojo/shell/BUILD.gn

Issue 603273003: Prevent static mojo builds from pulling //ui/gl into mojo_shell (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/shell/BUILD.gn
diff --git a/mojo/shell/BUILD.gn b/mojo/shell/BUILD.gn
index 320f4eba5478211ea1824633cd8f94b8701ba3ef..812c408f02492b2bd7ab2bc377c436c77a551524 100644
--- a/mojo/shell/BUILD.gn
+++ b/mojo/shell/BUILD.gn
@@ -11,7 +11,7 @@ executable("mojo_shell") {
"//base",
"//mojo/common",
"//mojo/environment:chromium",
- "//ui/gfx",
+ "//ui/gfx:switches",
jamesr 2014/09/25 20:14:07 for this since we just use the one constant honest
DaveMoore 2014/09/26 18:29:23 I hardcoded it. On 2014/09/25 20:14:07, jamesr wr
]
if (is_component_build) {
@@ -39,6 +39,7 @@ source_set("lib") {
"//mojo/services/public/interfaces/network",
"//mojo/spy",
"//mojo/system",
+ "//net",
jamesr 2014/09/25 20:09:44 why do we need //net ?
DaveMoore 2014/09/26 18:29:23 Accident. Removed. On 2014/09/25 20:09:44, jamesr
]
sources = [

Powered by Google App Engine
This is Rietveld 408576698