Prevent static mojo builds from pulling //ui/gl into mojo_shell

ui/gfx/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/ui.gni")
 
 if (is_android) {
   import("//build/config/android/config.gni")
   import("//build/config/android/rules.gni")
 }
 
 # Several targets want to include this header file, and some of them are
 # child dependencies of "gfx". Therefore, we separate it out here so multiple
 # targets can all have a dependency for header checking purposes without
 # creating circular dependencies.
 source_set("gfx_export") {
   sources = [
     "gfx_export.h",
   ]
 }
 
+source_set("switches") {

[jamesr, 2014/09/25 20:09:44]

the switches are exported from the gfx component, so linking them in separately
won't work. if you want to split this you you need to visibility-restrict it
into the gfx component and you cannot link it separately.

you could make this a separate component if you want it to be separately
linkable

[DaveMoore, 2014/09/26 18:29:23]

Copied switch instead.

On 2014/09/25 20:09:44, jamesr wrote:

+  sources = [
+    "switches.cc",
+    "switches.h",
+  ]
+}
+
 component("gfx") {
   sources = [
     "android/device_display_info.cc",
     "android/device_display_info.h",
     "android/gfx_jni_registrar.cc",
     "android/gfx_jni_registrar.h",
     "android/java_bitmap.cc",
     "android/java_bitmap.h",
     "android/scroller.cc",
     "android/scroller.h",
@@ skipping 148 matching lines @@
     "selection_model.cc",
     "selection_model.h",
     "sequential_id_generator.cc",
     "sequential_id_generator.h",
     "shadow_value.cc",
     "shadow_value.h",
     "skbitmap_operations.cc",
     "skbitmap_operations.h",
     "skia_util.cc",
     "skia_util.h",
-    "switches.cc",
-    "switches.h",
     "sys_color_change_listener.cc",
     "sys_color_change_listener.h",
     "text_constants.h",
     "text_elider.cc",
     "text_elider.h",
     "text_utils.cc",
     "text_utils.h",
     "text_utils_android.cc",
     "text_utils_ios.mm",
     "transform.cc",
@@ skipping 12 matching lines @@
     "win/singleton_hwnd.cc",
     "win/singleton_hwnd.h",
     "win/window_impl.cc",
     "win/window_impl.h",
   ]
 
   defines = [ "GFX_IMPLEMENTATION" ]
 
   deps = [
     ":gfx_export",
+    ":switches",
     "//base:i18n",
     "//base:base_static",
     "//base/third_party/dynamic_annotations",
     "//skia",
     "//third_party/harfbuzz-ng",
     "//third_party/libpng",
     "//third_party/zlib",
     "//ui/gfx/geometry",
   ]
   public_deps = [
@@ skipping 322 matching lines @@
 if (is_android) {
   generate_jni("gfx_jni_headers") {
     sources = [
       "../android/java/src/org/chromium/ui/gfx/BitmapHelper.java",
       "../android/java/src/org/chromium/ui/gfx/DeviceDisplayInfo.java",
       "../android/java/src/org/chromium/ui/gfx/ViewConfigurationHelper.java",
     ]
     jni_package = "gfx"
   }
 }