Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/base/BUILD.gn

Issue 603263003: [GN Build] Add a dependency on //third_party/mozilla to //ui/base on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/BUILD.gn
diff --git a/ui/base/BUILD.gn b/ui/base/BUILD.gn
index bc4e0c4d3115aad899409a0e19be2ab4d71d4472..8e0a870200b831c577c41ba6503bcbbd17c5efdf 100644
--- a/ui/base/BUILD.gn
+++ b/ui/base/BUILD.gn
@@ -528,8 +528,7 @@ component("base") {
if (is_mac) {
deps += [
- #TODO(tfarina): port this third_party component to GN.
- #"//third_party/mozilla",
+ "//third_party/mozilla",
]
sources -= [
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698