Issue 603263003: [GN Build] Add a dependency on //third_party/mozilla to //ui/base on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 603263003: [GN Build] Add a dependency on //third_party/mozilla to //ui/base on Mac. (Closed)

Created:
6 years, 2 months ago by Ilya Sherman

Modified:
6 years, 2 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

[GN Build] Add a dependency on //third_party/mozilla to //ui/base on Mac. BUG=none TEST=none R=avi@chromium.org Committed: https://crrev.com/84eeb930246ca5c093e429d0b869327b3b3abb38 Cr-Commit-Position: refs/heads/master@{#296889}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	ui/base/BUILD.gn	View		1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603263003/1

6 years, 2 months ago (2014-09-26 03:56:55 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as f606fac2c25f1abfdf817faa75bf218da895888c

6 years, 2 months ago (2014-09-26 05:22:11 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-09-26 05:22:54 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/84eeb930246ca5c093e429d0b869327b3b3abb38
Cr-Commit-Position: refs/heads/master@{#296889}