Issue 603263002: Seems that some of our compliers can't infer this type, though most can.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 603263002: Seems that some of our compliers can't infer this type, though most can. (Closed)

Created:
6 years, 2 months ago by mtklein_C

Modified:
6 years, 2 months ago

Reviewers:

CC:
reviews_skia.org, tfarina, bungeman-skia

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Seems that some of our compliers can't infer this type, though most can. BUG=skia: Committed: https://skia.googlesource.com/skia/+/587c5a2b8916b02c387e5e3369ad80589efe9ec1

Patch Set 1 #

Total comments: 1

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/core/SkPictureData.cpp	View		1 chunk	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mtklein_C

Committed patchset #1 (id:1) manually as 587c5a2 (presubmit successful).

6 years, 2 months ago (2014-09-25 19:07:58 UTC) #1

tfarina

https://codereview.chromium.org/603263002/diff/1/src/core/SkPictureData.cpp File src/core/SkPictureData.cpp (right): https://codereview.chromium.org/603263002/diff/1/src/core/SkPictureData.cpp#newcode122 src/core/SkPictureData.cpp:122: deepCopyInfo->paintData[i]->unflatten<SkPaintFlatteningTraits>( was this for msvc?

6 years, 2 months ago (2014-09-25 19:13:32 UTC) #2

mtklein

6 years, 2 months ago (2014-09-25 19:30:14 UTC) #3

Message was sent while issue was closed.

On 2014/09/25 19:13:32, tfarina wrote:
> https://codereview.chromium.org/603263002/diff/1/src/core/SkPictureData.cpp
> File src/core/SkPictureData.cpp (right):
> 
>
https://codereview.chromium.org/603263002/diff/1/src/core/SkPictureData.cpp#n...
> src/core/SkPictureData.cpp:122:
> deepCopyInfo->paintData[i]->unflatten<SkPaintFlatteningTraits>(
> was this for msvc?

Nope.  Chrome's clang. 
http://build.chromium.org/p/client.skia/builders/Linux%20Builder/builds/345/s...

Expand Messages | Collapse Messages