Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 603243005: Add an LSAN suppression for gin/object_template_builder.h. (Closed)

Created:
6 years, 2 months ago by Sam McNally
Modified:
6 years, 2 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add an LSAN suppression for gin/object_template_builder.h. BUG=416665 Committed: https://crrev.com/9bf611e58c7323d1574348c8df27f90ec8392add Cr-Commit-Position: refs/heads/master@{#297350}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Suppress gin/object_template_builder.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/lsan/suppressions.txt View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Sam McNally
6 years, 2 months ago (2014-09-29 00:51:33 UTC) #3
Yoyo Zhou
https://codereview.chromium.org/603243005/diff/20001/tools/lsan/suppressions.txt File tools/lsan/suppressions.txt (right): https://codereview.chromium.org/603243005/diff/20001/tools/lsan/suppressions.txt#newcode59 tools/lsan/suppressions.txt:59: leak:CreateTemplate I think we can do leak:gin/object_template_builder.h to be ...
6 years, 2 months ago (2014-09-30 01:21:54 UTC) #5
Sam McNally
https://codereview.chromium.org/603243005/diff/20001/tools/lsan/suppressions.txt File tools/lsan/suppressions.txt (right): https://codereview.chromium.org/603243005/diff/20001/tools/lsan/suppressions.txt#newcode59 tools/lsan/suppressions.txt:59: leak:CreateTemplate On 2014/09/30 01:21:54, Yoyo Zhou wrote: > I ...
6 years, 2 months ago (2014-09-30 01:28:20 UTC) #7
Yoyo Zhou
LGTM
6 years, 2 months ago (2014-09-30 02:24:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603243005/60001
6 years, 2 months ago (2014-09-30 02:40:01 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:60001) as 7e77608d51363a48c98be62f12d5de3ff75bf4d7
6 years, 2 months ago (2014-09-30 03:11:09 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/9bf611e58c7323d1574348c8df27f90ec8392add Cr-Commit-Position: refs/heads/master@{#297350}
6 years, 2 months ago (2014-09-30 03:11:50 UTC) #12
James Cook
6 years, 2 months ago (2014-09-30 15:35:08 UTC) #13
Message was sent while issue was closed. 
On 2014/09/30 03:11:50, I haz the power (commit-bot) wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/9bf611e58c7323d1574348c8df27f90ec8392add
> Cr-Commit-Position: refs/heads/master@{#297350}

Hooray! Thanks for taking care of this.

Powered by Google App Engine
This is Rietveld 408576698