Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 603243004: Fix a leak in extensions_unittests. (Closed)

Created:
6 years, 2 months ago by Sam McNally
Modified:
6 years, 2 months ago
Reviewers:
miket_OOO
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix a leak in extensions_unittests. BUG=406487, 416665 Committed: https://crrev.com/a7038bc15afb38421fd19868e5e7b17c6ac0dba4 Cr-Commit-Position: refs/heads/master@{#296931}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M extensions/test/data/unit_test_environment_specific_bindings.js View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sam McNally
6 years, 2 months ago (2014-09-26 04:06:51 UTC) #2
miket_OOO
LGTM and thanks!
6 years, 2 months ago (2014-09-26 13:30:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603243004/1
6 years, 2 months ago (2014-09-26 13:31:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 685335259960bb3a29da63fa5deedf36a4e10419
6 years, 2 months ago (2014-09-26 13:35:20 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 13:35:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a7038bc15afb38421fd19868e5e7b17c6ac0dba4
Cr-Commit-Position: refs/heads/master@{#296931}

Powered by Google App Engine
This is Rietveld 408576698