Mac: Fix tab strip relayout bug.

Mac: Fix tab strip relayout bug.

A CL was recently introduced that prevented unnecessary tab-strip relayouts.
(https://codereview.chromium.org/593223002/). That CL had a minor error where
it failed to relayout the tab strip when the left and right indentations
changed. This CL corrects that oversight.

This CL also refactors the browser_window_controller tab strip layout logic
into browser_window_layout. There is no intended behavioral change. The tab
strip layout logic now has test coverage.

BUG=415093
Committed: https://crrev.com/5eb473129dda33c370598739204470978be59af1
Cr-Commit-Position: refs/heads/master@{#296852}

[erikchen, 2014-09-25 18:31:09]

Patchset #1 (id:1) has been deleted

[erikchen, 2014-09-25 18:31:22]

erikchen@chromium.org changed reviewers:
+ andresantoso@chromium.org

[erikchen, 2014-09-25 18:31:22]

andresantoso: Please review.

[Andre, 2014-09-25 19:40:23]

lgtm

[erikchen, 2014-09-25 19:42:32]

erikchen@chromium.org changed reviewers:
+ rsesek@chromium.org

[erikchen, 2014-09-25 19:42:33]

rsesek: Looking for an OWNER review.

[Robert Sesek, 2014-09-25 19:44:11]

https://codereview.chromium.org/603243002/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right):

https://codereview.chromium.org/603243002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:197:
requiresRelayout = YES;
BOOL requiresRelayout = !NSEqualRects(tabStripFrame, [tabStripView frame]);

[erikchen, 2014-09-25 20:03:33]

https://codereview.chromium.org/603243002/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right):

https://codereview.chromium.org/603243002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:197:
requiresRelayout = YES;
On 2014/09/25 19:44:10, Robert Sesek wrote:
> BOOL requiresRelayout = !NSEqualRects(tabStripFrame, [tabStripView frame]);

Done.

[Robert Sesek, 2014-09-25 20:23:11]

LGTM. It would probably be good to test this logic, though.

[erikchen, 2014-09-25 23:36:59]

Patchset #3 (id:60001) has been deleted

[erikchen, 2014-09-25 23:37:25]

Patchset #3 (id:80001) has been deleted

[erikchen, 2014-09-25 23:39:50]

Tests being added in this CL: https://codereview.chromium.org/607723002/ (it got
large enough that I'm breaking it out of this CL)

[erikchen, 2014-09-25 23:39:59]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2014-09-25 23:42:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/603243002/40001

[commit-bot: I haz the power, 2014-09-26 01:40:45]

Committed patchset #2 (id:40001) as d46d29cdabd6e1dda8a658587ad2ae0bce427544

[commit-bot: I haz the power, 2014-09-26 01:41:23]

Patchset 2 (id:??) landed as
https://crrev.com/5eb473129dda33c370598739204470978be59af1
Cr-Commit-Position: refs/heads/master@{#296852}