Issue 60323007: Moved app_list_service_linux to chrome/browser/ui/views.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 60323007: Moved app_list_service_linux to chrome/browser/ui/views. (Closed)

Created:
7 years, 1 month ago by Matt Giuca

Modified:
7 years, 1 month ago

Reviewers:
koz (OOO until 15th September)

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Moved app_list_service_linux to chrome/browser/ui/views. For DEPS reasons (this file needs to reference the views directory in an upcoming CL). BUG=299250 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233526

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -160 lines)			Patch
D	chrome/browser/ui/app_list/app_list_service_linux.h	View	1 chunk	+0 lines, -41 lines	0 comments	Download
D	chrome/browser/ui/app_list/app_list_service_linux.cc	View	1 chunk	+0 lines, -67 lines	0 comments	Download
D	chrome/browser/ui/app_list/test/app_list_service_test_api_linux.cc	View	1 chunk	+0 lines, -42 lines	0 comments	Download
A +	chrome/browser/ui/views/app_list/linux/app_list_service_linux.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	chrome/browser/ui/views/app_list/linux/app_list_service_linux.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	chrome/browser/ui/views/app_list/linux/test/app_list_service_test_api_linux.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	3 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

Matt Giuca

Rationale: app_list_service_linux.cc will need to #include app_list_linux.h which needs to be in views. There is ...

7 years, 1 month ago (2013-11-07 01:24:02 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/60323007/1

7 years, 1 month ago (2013-11-07 02:08:05 UTC) #3

Message was sent while issue was closed.

Change committed as 233526