Adding operator== to TimingFunctionTestHelper.

Adding operator== to TimingFunctionTestHelper.

DEPENDS=https://codereview.chromium.org/60033004/ - Don't check all animation/transition properties when comparing RenderStyles
BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161676

[mithro-old, 2013-11-06 04:01:44]

Hi Steve,

Here is the operator== moved into the TimingFunctionTestHelper so it can be used
in tests. 

It requires your https://codereview.chromium.org/60033004/ patch.

Tim

[Steve Block, 2013-11-06 05:47:19]

lgtm

https://codereview.chromium.org/60323005/diff/1/Source/core/platform/animatio...
File Source/core/platform/animation/TimingFunctionTestHelper.cpp (right):

https://codereview.chromium.org/60323005/diff/1/Source/core/platform/animatio...
Source/core/platform/animation/TimingFunctionTestHelper.cpp:81: bool minMaxEq =
(lhs.m_min == rhs.m_min) && (lhs.m_max == rhs.m_max);
Does this need a local?

https://codereview.chromium.org/60323005/diff/1/Source/core/platform/animatio...
Source/core/platform/animation/TimingFunctionTestHelper.cpp:88: if
(!lhs.m_timingFunction || !rhs.m_timingFunction)
m_timingFunction should always be non-null. You could assert this in the Segment
c'tor.

https://codereview.chromium.org/60323005/diff/1/Source/core/platform/animatio...
Source/core/platform/animation/TimingFunctionTestHelper.cpp:98: // PrintTo
functions
Again, this comment isn't really needed.

https://codereview.chromium.org/60323005/diff/1/Source/core/platform/animatio...
Source/core/platform/animation/TimingFunctionTestHelper.cpp:233: return
((*linear) == rhs);
No need for these inner parens

https://codereview.chromium.org/60323005/diff/1/Source/core/platform/animatio...
Source/core/platform/animation/TimingFunctionTestHelper.cpp:245: return
((*chained) == rhs);
Still don't see why we can't call ChainedTimingFunctionTestHelper::equals(lhs,
rhs) here?

https://codereview.chromium.org/60323005/diff/1/Source/core/platform/animatio...
File Source/core/platform/animation/TimingFunctionTestHelper.h (right):

https://codereview.chromium.org/60323005/diff/1/Source/core/platform/animatio...
Source/core/platform/animation/TimingFunctionTestHelper.h:45: // PrintTo
functions
These comments don't add much!

[mithro-old, 2013-11-06 23:37:17]

https://codereview.chromium.org/60323005/diff/1/Source/core/platform/animatio...
File Source/core/platform/animation/TimingFunctionTestHelper.cpp (right):

https://codereview.chromium.org/60323005/diff/1/Source/core/platform/animatio...
Source/core/platform/animation/TimingFunctionTestHelper.cpp:81: bool minMaxEq =
(lhs.m_min == rhs.m_min) && (lhs.m_max == rhs.m_max);
On 2013/11/06 05:47:19, Steve Block wrote:
> Does this need a local?

Done.

https://codereview.chromium.org/60323005/diff/1/Source/core/platform/animatio...
Source/core/platform/animation/TimingFunctionTestHelper.cpp:88: if
(!lhs.m_timingFunction || !rhs.m_timingFunction)
On 2013/11/06 05:47:19, Steve Block wrote:
> m_timingFunction should always be non-null. You could assert this in the
Segment
> c'tor.

Converted these to ASSERTs and added an ASSERT to c'tor.

https://codereview.chromium.org/60323005/diff/1/Source/core/platform/animatio...
Source/core/platform/animation/TimingFunctionTestHelper.cpp:98: // PrintTo
functions
On 2013/11/06 05:47:19, Steve Block wrote:
> Again, this comment isn't really needed.

Done.

https://codereview.chromium.org/60323005/diff/1/Source/core/platform/animatio...
Source/core/platform/animation/TimingFunctionTestHelper.cpp:233: return
((*linear) == rhs);
On 2013/11/06 05:47:19, Steve Block wrote:
> No need for these inner parens

Done.

https://codereview.chromium.org/60323005/diff/1/Source/core/platform/animatio...
Source/core/platform/animation/TimingFunctionTestHelper.cpp:245: return
((*chained) == rhs);
On 2013/11/06 05:47:19, Steve Block wrote:
> Still don't see why we can't call ChainedTimingFunctionTestHelper::equals(lhs,
> rhs) here?

We could, but we'd still need the following operator;
 221 bool operator==(const ChainedTimingFunction& lhs, const TimingFunction&
rhs)

So just being consistent with the other switch paths seems nicer.

[commit-bot: I haz the power, 2013-11-08 02:18:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mithro@mithis.com/60323005/160001

[commit-bot: I haz the power, 2013-11-08 03:35:17]

Retried try job too often on linux_blink_rel for step(s) weborigin_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2013-11-08 03:37:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mithro@mithis.com/60323005/160001

[commit-bot: I haz the power, 2013-11-08 04:47:33]

Retried try job too often on linux_blink_rel for step(s) weborigin_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2013-11-08 08:38:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mithro@mithis.com/60323005/160001

[commit-bot: I haz the power, 2013-11-08 09:47:23]

Retried try job too often on linux_blink_rel for step(s) weborigin_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2013-11-09 04:07:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mithro@mithis.com/60323005/160001

[commit-bot: I haz the power, 2013-11-09 05:41:11]

Change committed as 161676