Issue 60323002: Revert 232547 "Pepper: Move FileIO host from renderer to browser."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 60323002: Revert 232547 "Pepper: Move FileIO host from renderer to browser." (Closed)

Created:
7 years, 1 month ago by teravest

Modified:
7 years, 1 month ago

Reviewers:
teravest

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 232547 "Pepper: Move FileIO host from renderer to browser." This change is being reverted due to some problems seen in integration testing. See http://crbug.com/314884 for test failure details. > Pepper: Move FileIO host from renderer to browser. > > This change is large because it moves QuotaFileIO and PepperFileIOHost all at > once to the browser process. Some code in the refactored PepperFileIOHost is > moved from what's provided in FileAPIMessageFilter. > > Tested locally with Bastion, From Dust, and Angry Bots. > > TBR=jschuh > BUG=246396 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232440 > > Review URL: https://codereview.chromium.org/33053002 TBR=teravest@chromium.org BUG=246396, 314884 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233014

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+346 lines, -1698 lines)			Patch
M	trunk/src/chrome/browser/chrome_content_browser_client.cc	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	trunk/src/chrome/browser/sync_file_system/local/syncable_file_system_operation.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/sync_file_system/local/syncable_file_system_operation.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	trunk/src/chrome/renderer/chrome_content_renderer_client.h	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	trunk/src/chrome/renderer/chrome_content_renderer_client.cc	View	2 chunks	+29 lines, -0 lines	0 comments	Download
M	trunk/src/content/browser/fileapi/fileapi_message_filter.h	View	4 chunks	+18 lines, -0 lines	0 comments	Download
M	trunk/src/content/browser/fileapi/fileapi_message_filter.cc	View	6 chunks	+133 lines, -0 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/pepper/content_browser_pepper_host_factory.cc	View	2 chunks	+0 lines, -5 lines	0 comments	Download
D	trunk/src/content/browser/renderer_host/pepper/pepper_file_io_host.h	View	1 chunk	+0 lines, -150 lines	0 comments	Download
D	trunk/src/content/browser/renderer_host/pepper/pepper_file_io_host.cc	View	1 chunk	+0 lines, -598 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/pepper/pepper_file_ref_host.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/pepper/pepper_file_ref_host.cc	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/pepper/pepper_file_system_browser_host.cc	View	1 chunk	+5 lines, -3 lines	0 comments	Download
D	trunk/src/content/browser/renderer_host/pepper/quota_file_io.h	View	1 chunk	+0 lines, -127 lines	0 comments	Download
D	trunk/src/content/browser/renderer_host/pepper/quota_file_io.cc	View	1 chunk	+0 lines, -359 lines	0 comments	Download
D	trunk/src/content/browser/renderer_host/pepper/quota_file_io_unittest.cc	View	1 chunk	+0 lines, -426 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/render_message_filter.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/render_message_filter.cc	View	3 chunks	+30 lines, -0 lines	0 comments	Download
M	trunk/src/content/child/fileapi/file_system_dispatcher.h	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	trunk/src/content/child/fileapi/file_system_dispatcher.cc	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	trunk/src/content/common/fileapi/file_system_messages.h	View	2 chunks	+18 lines, -0 lines	0 comments	Download
M	trunk/src/content/common/view_messages.h	View	2 chunks	+12 lines, -0 lines	0 comments	Download
M	trunk/src/content/content_browser.gypi	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	trunk/src/content/content_renderer.gypi	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	trunk/src/content/content_tests.gypi	View	2 chunks	+1 line, -1 line	0 comments	Download
M	trunk/src/content/public/renderer/content_renderer_client.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	trunk/src/content/public/renderer/content_renderer_client.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	trunk/src/content/renderer/pepper/content_renderer_pepper_host_factory.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
A +	trunk/src/content/renderer/pepper/pepper_file_io_host.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/content/renderer/pepper/pepper_file_io_host.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/content/renderer/pepper/quota_file_io.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/content/renderer/pepper/quota_file_io.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/content/renderer/pepper/quota_file_io_unittest.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	trunk/src/ppapi/proxy/file_io_resource.cc	View	8 chunks	+8 lines, -8 lines	0 comments	Download
M	trunk/src/webkit/browser/fileapi/file_system_operation.h	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	trunk/src/webkit/browser/fileapi/file_system_operation_impl.h	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	trunk/src/webkit/browser/fileapi/file_system_operation_impl.cc	View	4 chunks	+10 lines, -3 lines	0 comments	Download
M	trunk/src/webkit/browser/fileapi/file_system_operation_runner.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	trunk/src/webkit/browser/fileapi/file_system_operation_runner.cc	View	4 chunks	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r233014.

Expand Messages | Collapse Messages