Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/web/PopupMenuChromium.h

Issue 603193005: Move the Widget hierarchy to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased upto r183571 Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/platform/Widget.h ('K') | « Source/web/PopupListBox.cpp ('k') | Source/web/PopupMenuChromium.cpp » ('j') | Source/web/WebHelperPluginImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/PopupMenuChromium.h
diff --git a/Source/web/PopupMenuChromium.h b/Source/web/PopupMenuChromium.h
index d493a3e77f85c4efc9f13c30fbc6a5a36b86bb0c..33e0d9f20e1d3e6e2b56d34091601f239cf35c75 100644
--- a/Source/web/PopupMenuChromium.h
+++ b/Source/web/PopupMenuChromium.h
@@ -51,10 +51,14 @@ public:
virtual void updateFromElement() override;
virtual void disconnectClient() override;
+ virtual void trace(Visitor*) OVERRIDE;
+
private:
+ void dispose();
+
PopupMenuClient* m_popupClient;
- RefPtr<FrameView> m_frameView;
- RefPtr<PopupContainer> m_popup;
+ RefPtrWillBeMember<FrameView> m_frameView;
+ RefPtrWillBeMember<PopupContainer> m_popup;
};
} // namespace blink
« Source/platform/Widget.h ('K') | « Source/web/PopupListBox.cpp ('k') | Source/web/PopupMenuChromium.cpp » ('j') | Source/web/WebHelperPluginImpl.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698