Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: Source/core/accessibility/AXScrollView.h

Issue 603193005: Move the Widget hierarchy to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased upto r183571 Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/accessibility/AXScrollView.h
diff --git a/Source/core/accessibility/AXScrollView.h b/Source/core/accessibility/AXScrollView.h
index 7df4d9708897c7667673b7a7c6b896576357afa6..caa0963f27e699d2fb6711da1ca64fa4ed14b89f 100644
--- a/Source/core/accessibility/AXScrollView.h
+++ b/Source/core/accessibility/AXScrollView.h
@@ -75,6 +75,16 @@ private:
AXScrollbar* addChildScrollbar(Scrollbar*);
void removeChildScrollbar(AXObject*);
+ // FIXME: Oilpan: Frame/ScrollView is on the heap and its
+ // AXScrollView is detached&removed from the AX cache when the
+ // FrameView is disposed. Which clears m_scrollView, hence this
+ // bare pointer will not be stale, so the bare pointer use is safe
+ // & acceptable.
+ //
+ // However, it would be preferable to have it be normally traced
+ // as part of moving the AX objects to the heap. Temporarily using
+ // a Persistent risks creating a FrameView leak, and brings no
+ // real benefits overall.
FrameView* m_scrollView;
RefPtr<AXObject> m_horizontalScrollbar;
RefPtr<AXObject> m_verticalScrollbar;

Powered by Google App Engine
This is Rietveld 408576698