Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1482)

Unified Diff: Source/web/PopupContainer.h

Issue 603193005: Move the Widget hierarchy to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase upto and resolve r182737 conflict. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/PopupContainer.h
diff --git a/Source/web/PopupContainer.h b/Source/web/PopupContainer.h
index d136ad45dba2a1a805eec88e41fe3ad376466566..f88b5feb926cddfdd9b180498face0e22934efbc 100644
--- a/Source/web/PopupContainer.h
+++ b/Source/web/PopupContainer.h
@@ -34,6 +34,7 @@
#include "platform/PopupMenuStyle.h"
#include "platform/geometry/FloatQuad.h"
+#include "platform/heap/Handle.h"
#include "web/PopupListBox.h"
namespace blink {
@@ -49,7 +50,7 @@ struct WebPopupMenuInfo;
// FIXME(skobes): This class can probably be combined with PopupListBox.
class PopupContainer FINAL : public Widget {
public:
- static PassRefPtr<PopupContainer> create(PopupMenuClient*, bool deviceSupportsTouch);
+ static PassRefPtrWillBeRawPtr<PopupContainer> create(PopupMenuClient*, bool deviceSupportsTouch);
// Whether a key event should be sent to this popup.
bool isInterestedInEventForKey(int keyCode);
@@ -124,6 +125,8 @@ public:
void updateFromElement() { m_listBox->updateFromElement(); }
+ virtual void trace(Visitor*) OVERRIDE;
+
private:
friend class WTF::RefCounted<PopupContainer>;
@@ -144,8 +147,8 @@ private:
// Returns the ChromeClient of the page this popup is associated with.
ChromeClient& chromeClient();
- RefPtr<PopupListBox> m_listBox;
- RefPtr<FrameView> m_frameView;
+ RefPtrWillBeMember<PopupListBox> m_listBox;
+ RefPtrWillBeMember<FrameView> m_frameView;
// m_controlPosition contains the transformed position of the
// <select>/<input> associated with this popup. m_controlSize is the size

Powered by Google App Engine
This is Rietveld 408576698