Chromium Code Reviews| Index: Source/core/css/MediaQueryEvaluatorTest.cpp |
| diff --git a/Source/core/css/MediaQueryEvaluatorTest.cpp b/Source/core/css/MediaQueryEvaluatorTest.cpp |
| index f982909ebcdd6a8cf1c5baf3b393ed6ee0e9e56c..fcc6cae88a32292bc5230d0ce705c92058771466 100644 |
| --- a/Source/core/css/MediaQueryEvaluatorTest.cpp |
| +++ b/Source/core/css/MediaQueryEvaluatorTest.cpp |
| @@ -77,8 +77,9 @@ TestCase printTestCases[] = { |
| void testMQEvaluator(TestCase* testCases, const MediaQueryEvaluator& mediaQueryEvaluator) |
| { |
| + RefPtrWillBePersistent<MediaQuerySet> querySet = nullptr; |
|
haraken
2014/09/26 09:19:25
RefPtrWillBeRawPtr ?
sof
2014/09/26 09:41:05
We had several rounds of this in ImageBitmapTest &
haraken
2014/09/26 09:50:25
oh, this is in a test. Makes sense to use a Persis
|
| for (unsigned i = 0; testCases[i].input; ++i) { |
| - RefPtrWillBeRawPtr<MediaQuerySet> querySet = MediaQuerySet::create(testCases[i].input); |
| + querySet = MediaQuerySet::create(testCases[i].input); |
| ASSERT_EQ(testCases[i].output, mediaQueryEvaluator.eval(querySet.get())); |
| } |
| } |
| @@ -125,10 +126,10 @@ TEST(MediaQueryEvaluatorTest, Dynamic) |
| TEST(MediaQueryEvaluatorTest, DynamicNoView) |
| { |
| OwnPtr<DummyPageHolder> pageHolder = DummyPageHolder::create(IntSize(500, 500)); |
| - RefPtr<FrameView> view = pageHolder->frame().view(); |
| + RefPtrWillBePersistent<FrameView> view = pageHolder->frame().view(); |
|
haraken
2014/09/26 09:19:25
RefPtrWillBeRawPtr ?
|
| pageHolder->frame().setView(nullptr); |
| MediaQueryEvaluator mediaQueryEvaluator(&pageHolder->frame()); |
| - RefPtrWillBeRawPtr<MediaQuerySet> querySet = MediaQuerySet::create("foobar"); |
| + RefPtrWillBePersistent<MediaQuerySet> querySet = MediaQuerySet::create("foobar"); |
|
haraken
2014/09/26 09:19:25
RefPtrWillBeRawPtr ?
|
| bool output = false; |
| ASSERT_EQ(output, mediaQueryEvaluator.eval(querySet.get())); |
| pageHolder->frame().setView(view); |