Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1916)

Unified Diff: Source/web/WebPluginContainerImpl.h

Issue 603193005: Move the Widget hierarchy to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase needed again Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WebPluginContainerImpl.h
diff --git a/Source/web/WebPluginContainerImpl.h b/Source/web/WebPluginContainerImpl.h
index 5f390335640575b745605eefe4bba6c2d88cb172..363e5d697f753a36d8abfe7a80db5bc2dcf80583 100644
--- a/Source/web/WebPluginContainerImpl.h
+++ b/Source/web/WebPluginContainerImpl.h
@@ -54,6 +54,7 @@ class MouseEvent;
class PlatformGestureEvent;
class ResourceError;
class ResourceResponse;
+class ScriptController;
class ScrollbarGroup;
class TouchEvent;
class WebPlugin;
@@ -63,17 +64,12 @@ class WheelEvent;
class Widget;
struct WebPrintParams;
-class WebPluginContainerImpl final
- : public PluginView
- , public WebPluginContainer
-#if !ENABLE(OILPAN)
- , public FrameDestructionObserver
-#endif
- {
+class WebPluginContainerImpl final : public PluginView, public WebPluginContainer, public FrameDestructionObserver {
+ WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(WebPluginContainerImpl);
public:
- static PassRefPtr<WebPluginContainerImpl> create(HTMLPlugInElement* element, WebPlugin* webPlugin)
+ static PassRefPtrWillBeRawPtr<WebPluginContainerImpl> create(HTMLPlugInElement* element, WebPlugin* webPlugin)
{
- return adoptRef(new WebPluginContainerImpl(element, webPlugin));
+ return adoptRefWillBeNoop(new WebPluginContainerImpl(element, webPlugin));
}
// PluginView methods
@@ -169,9 +165,10 @@ public:
bool paintCustomOverhangArea(GraphicsContext*, const IntRect&, const IntRect&, const IntRect&);
-#if ENABLE(OILPAN)
- virtual void detach() override;
-#endif
+ virtual void trace(Visitor*) override;
+ virtual void dispose() override;
+
+ virtual LocalFrame* pluginFrame() const override { return frame(); }
private:
WebPluginContainerImpl(HTMLPlugInElement*, WebPlugin*);
@@ -198,25 +195,7 @@ private:
const IntRect& frameRect,
Vector<IntRect>& cutOutRects);
-#if ENABLE(OILPAN)
- // FIXME: Oilpan: consider moving Widget to the heap, allowing this
- // container object to be a FrameDestructionObserver. And thereby
- // keep a traced member reference to the frame rather than as a
- // bare pointer. Instead, the owning object (HTMLFrameOwnerElement)
- // explicitly deletes this object when it is disconnected from its
- // frame. Any access to an invalid frame via this bare pointer
- // is therefore not possible.
- //
- // See the HTMLFrameOwnerElement::disconnectContentFrame comment for
- // (even) more.
- LocalFrame* m_frame;
-
- LocalFrame* frame() const { return m_frame; }
-#endif
-
- // FIXME: see above; for the time being, a bare pointer to the owning
- // HTMLPlugInElement and managed as such.
- HTMLPlugInElement* m_element;
+ RawPtrWillBeMember<HTMLPlugInElement> m_element;
WebPlugin* m_webPlugin;
Vector<WebPluginLoadObserver*> m_pluginLoadObservers;

Powered by Google App Engine
This is Rietveld 408576698