Source/web/tests/WebFrameTest.cpp - Issue 603193005: Move the Widget hierarchy to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/WebFrameTest.cpp

Issue 603193005: Move the Widget hierarchy to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix popup unit tests Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/tests/WebFrameTest.cpp

diff --git a/Source/web/tests/WebFrameTest.cpp b/Source/web/tests/WebFrameTest.cpp

index 9d4971d0a10b89d8c4bf6670c6f089e4d937bba3..f7738122803e58dd146d1db7c8819e5e3891900a 100644

--- a/Source/web/tests/WebFrameTest.cpp

+++ b/Source/web/tests/WebFrameTest.cpp

@@ -3813,7 +3813,7 @@ TEST_F(WebFrameTest, SetTickmarks)

// Get the tickmarks for the original find request.

FrameView* frameView = webViewHelper.webViewImpl()->mainFrameImpl()->frameView();

- RefPtr<Scrollbar> scrollbar = frameView->createScrollbar(HorizontalScrollbar);

+ RefPtrWillBeRawPtr<Scrollbar> scrollbar = frameView->createScrollbar(HorizontalScrollbar);

Vector<IntRect> originalTickmarks;

scrollbar->getTickmarks(originalTickmarks);

EXPECT_EQ(4u, originalTickmarks.size());