Source/web/FrameLoaderClientImpl.h - Issue 603193005: Move the Widget hierarchy to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/FrameLoaderClientImpl.h

Issue 603193005: Move the Widget hierarchy to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix popup unit tests Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/FrameLoaderClientImpl.h

diff --git a/Source/web/FrameLoaderClientImpl.h b/Source/web/FrameLoaderClientImpl.h

index 398caf7d03eb83c3ab50a5b68ea62dc9b31f2b48..7e49e2151ce7720c4045cb4595368c90983eb230 100644

--- a/Source/web/FrameLoaderClientImpl.h

+++ b/Source/web/FrameLoaderClientImpl.h

@@ -118,11 +118,11 @@ public:

virtual void transitionToCommittedForNewPage() OVERRIDE;

virtual PassRefPtrWillBeRawPtr<LocalFrame> createFrame(const KURL&, const WTF::AtomicString& name, const Referrer&, HTMLFrameOwnerElement*) OVERRIDE;

virtual bool canCreatePluginWithoutRenderer(const String& mimeType) const;

- virtual PassRefPtr<Widget> createPlugin(

+ virtual PassRefPtrWillBeRawPtr<Widget> createPlugin(

HTMLPlugInElement*, const KURL&,

const Vector<WTF::String>&, const Vector<WTF::String>&,

const WTF::String&, bool loadManually, DetachedPluginPolicy) OVERRIDE;

- virtual PassRefPtr<Widget> createJavaAppletWidget(

+ virtual PassRefPtrWillBeRawPtr<Widget> createJavaAppletWidget(

HTMLAppletElement*,

const KURL& /* base_url */,

const Vector<WTF::String>& paramNames,