Source/core/plugins/PluginView.h - Issue 603193005: Move the Widget hierarchy to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/plugins/PluginView.h

Issue 603193005: Move the Widget hierarchy to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix popup unit tests Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/plugins/PluginView.h

diff --git a/Source/core/plugins/PluginView.h b/Source/core/plugins/PluginView.h

index b7af6c68a45b66ada177df45b1c06c343e204adc..79bea58d041095ac493c583abeb1a0a8e98870f7 100644

--- a/Source/core/plugins/PluginView.h

+++ b/Source/core/plugins/PluginView.h

@@ -59,6 +59,8 @@ public:

virtual void didFinishLoading() { }

virtual void didFailLoading(const ResourceError&) { }

+ virtual void dispose() { }

protected:

PluginView() : Widget() { }

};