Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/core/accessibility/AXScrollView.h

Issue 603193005: Move the Widget hierarchy to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix popup unit tests Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/accessibility/AXObjectCache.cpp ('k') | Source/core/accessibility/AXScrollbar.h » ('j') | Source/core/frame/FrameView.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/accessibility/AXScrollView.h
diff --git a/Source/core/accessibility/AXScrollView.h b/Source/core/accessibility/AXScrollView.h
index fbe205301e42f7ab1cda1d146f17dd49d697d7a0..2565ff7ef4862c90109273e85244a6e457fd562f 100644
--- a/Source/core/accessibility/AXScrollView.h
+++ b/Source/core/accessibility/AXScrollView.h
@@ -75,6 +75,11 @@ private:
AXScrollbar* addChildScrollbar(Scrollbar*);
void removeChildScrollbar(AXObject*);
+ // FIXME: Oilpan: Frame/ScrollView is on the heap, but can we
+ // assume that the corresponding AXScrollView is retired from
+ // the AX cache before it is finalized? If so, maintaining
+ // this as a bare pointer appears preferable. A persistent
+ // could create a leak.
ScrollView* m_scrollView;
RefPtr<AXObject> m_horizontalScrollbar;
RefPtr<AXObject> m_verticalScrollbar;
« no previous file with comments | « Source/core/accessibility/AXObjectCache.cpp ('k') | Source/core/accessibility/AXScrollbar.h » ('j') | Source/core/frame/FrameView.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698