Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Unified Diff: Source/web/WebViewImpl.cpp

Issue 603193005: Move the Widget hierarchy to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Switch LocalFrame::m_pluginElements rep to HashSet<HTMLPlugInElement*> Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WebViewImpl.cpp
diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp
index 78b4ff5c2a6f5fce5633f5afcc8a717afff98ad7..86c2479776e064a3dae50b827773ccfb6bb68ff0 100644
--- a/Source/web/WebViewImpl.cpp
+++ b/Source/web/WebViewImpl.cpp
@@ -490,7 +490,7 @@ void WebViewImpl::handleMouseDown(LocalFrame& mainFrame, const WebMouseEvent& ev
// If there is a popup open, close it as the user is clicking on the page (outside of the
// popup). We also save it so we can prevent a click on an element from immediately
// reopening the same popup.
- RefPtr<PopupContainer> selectPopup;
+ RefPtrWillBeRawPtr<PopupContainer> selectPopup = nullptr;
RefPtr<WebPagePopupImpl> pagePopup;
if (event.button == WebMouseEvent::ButtonLeft) {
selectPopup = m_selectPopup;
@@ -738,7 +738,7 @@ bool WebViewImpl::handleGestureEvent(const WebGestureEvent& event)
break;
}
- RefPtr<PopupContainer> selectPopup;
+ RefPtrWillBeRawPtr<PopupContainer> selectPopup = nullptr;
selectPopup = m_selectPopup;
hideSelectPopup();
ASSERT(!m_selectPopup);
@@ -3282,7 +3282,7 @@ void WebViewImpl::updateMainFrameLayoutSize()
if (m_shouldAutoResize || !mainFrameImpl())
return;
- RefPtr<FrameView> view = mainFrameImpl()->frameView();
+ RefPtrWillBeRawPtr<FrameView> view = mainFrameImpl()->frameView();
if (!view)
return;

Powered by Google App Engine
This is Rietveld 408576698