Source/web/FrameLoaderClientImpl.h - Issue 603193005: Move the Widget hierarchy to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/FrameLoaderClientImpl.h

Issue 603193005: Move the Widget hierarchy to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Switch LocalFrame::m_pluginElements rep to HashSet<HTMLPlugInElement*> Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/FrameLoaderClientImpl.h

diff --git a/Source/web/FrameLoaderClientImpl.h b/Source/web/FrameLoaderClientImpl.h

index 878650d85df9b0d850e276af85839416d1235e25..3c5082e2f30b60aa8e5c728cb4201aa07a2e0177 100644

--- a/Source/web/FrameLoaderClientImpl.h

+++ b/Source/web/FrameLoaderClientImpl.h

@@ -122,11 +122,11 @@ public:

Document&, const KURL&,

const Vector<String>& paramNames, const Vector<String>& paramValues,

const String& mimeType, bool loadManually) override;

- virtual PassRefPtr<Widget> createPlugin(

+ virtual PassRefPtrWillBeRawPtr<Widget> createPlugin(

HTMLPlugInElement*, const KURL&,

const Vector<WTF::String>&, const Vector<WTF::String>&,

const WTF::String&, bool loadManually, DetachedPluginPolicy) override;

- virtual PassRefPtr<Widget> createJavaAppletWidget(

+ virtual PassRefPtrWillBeRawPtr<Widget> createJavaAppletWidget(

HTMLAppletElement*,

const KURL& /* base_url */,

const Vector<WTF::String>& paramNames,