Source/core/rendering/RenderLayerScrollableArea.h - Issue 603193005: Move the Widget hierarchy to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderLayerScrollableArea.h

Issue 603193005: Move the Widget hierarchy to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Switch LocalFrame::m_pluginElements rep to HashSet<HTMLPlugInElement*> Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderLayerScrollableArea.h

diff --git a/Source/core/rendering/RenderLayerScrollableArea.h b/Source/core/rendering/RenderLayerScrollableArea.h

index 8cf5b64d82d74631b63bb8b01edd70e608f4b03c..2d983c06fbbe36750a1448c6060b96b0e5354da8 100644

--- a/Source/core/rendering/RenderLayerScrollableArea.h

+++ b/Source/core/rendering/RenderLayerScrollableArea.h

@@ -200,7 +200,7 @@ private:

LayoutUnit horizontalScrollbarStart(int minX) const;

IntSize scrollbarOffset(const Scrollbar*) const;

- PassRefPtr<Scrollbar> createScrollbar(ScrollbarOrientation);

+ PassRefPtrWillBeRawPtr<Scrollbar> createScrollbar(ScrollbarOrientation);

void destroyScrollbar(ScrollbarOrientation);

void setHasHorizontalScrollbar(bool hasScrollbar);

@@ -247,8 +247,8 @@ private:

IntPoint m_cachedOverlayScrollbarOffset;

// For areas with overflow, we have a pair of scrollbars.

- RefPtr<Scrollbar> m_hBar;

- RefPtr<Scrollbar> m_vBar;

+ RefPtrWillBePersistent<Scrollbar> m_hBar;

+ RefPtrWillBePersistent<Scrollbar> m_vBar;

// Renderers to hold our custom scroll corner.

RawPtrWillBePersistent<RenderScrollbarPart> m_scrollCorner;