Source/core/html/HTMLAppletElement.cpp - Issue 603193005: Move the Widget hierarchy to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLAppletElement.cpp

Issue 603193005: Move the Widget hierarchy to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Switch LocalFrame::m_pluginElements rep to HashSet<HTMLPlugInElement*> Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLAppletElement.cpp

diff --git a/Source/core/html/HTMLAppletElement.cpp b/Source/core/html/HTMLAppletElement.cpp

index eb955365b27074cb447797d1c29c64c09352641a..53ed03d7854ae554de0b4f3745d15a0f79bbd137 100644

--- a/Source/core/html/HTMLAppletElement.cpp

+++ b/Source/core/html/HTMLAppletElement.cpp

@@ -183,8 +183,8 @@ void HTMLAppletElement::updateWidgetInternal()

paramValues.append(param->value());

}

- OwnPtrWillBeRawPtr<PluginPlaceholder> placeholder;

- RefPtr<Widget> widget;

+ OwnPtrWillBeRawPtr<PluginPlaceholder> placeholder = nullptr;

+ RefPtrWillBeRawPtr<Widget> widget = nullptr;

if (frame->loader().allowPlugins(AboutToInstantiatePlugin)) {

placeholder = frame->loader().client()->createPluginPlaceholder(document(), KURL(), paramNames, paramValues, m_serviceType, false);

if (!placeholder)