Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: Source/platform/exported/WebScrollbarImpl.h

Issue 603193005: Move the Widget hierarchy to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add ~Scrollbar assert Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/exported/WebScrollbarImpl.h
diff --git a/Source/platform/exported/WebScrollbarImpl.h b/Source/platform/exported/WebScrollbarImpl.h
index aa07b4e3ee206fbcc52d527d3be854a629f88237..398fe36ba57ddb39c7464982a632c9afb6e6057b 100644
--- a/Source/platform/exported/WebScrollbarImpl.h
+++ b/Source/platform/exported/WebScrollbarImpl.h
@@ -26,14 +26,18 @@
#define WebScrollbarImpl_h
#include "platform/PlatformExport.h"
+#include "platform/heap/Handle.h"
#include "public/platform/WebScrollbar.h"
namespace blink {
class Scrollbar;
-class PLATFORM_EXPORT WebScrollbarImpl : public WebScrollbar {
+class PLATFORM_EXPORT WebScrollbarImpl FINAL : public WebScrollbar {
haraken 2014/09/29 14:16:36 FINAL => final
sof 2014/10/02 14:03:54 Done.
public:
- explicit WebScrollbarImpl(Scrollbar*);
+ static WebScrollbarImpl* create(Scrollbar* scrollbar)
+ {
+ return new WebScrollbarImpl(scrollbar);
+ }
// Implement WebScrollbar methods
virtual bool isOverlay() const OVERRIDE;
@@ -57,7 +61,9 @@ public:
virtual void setIsAlphaLocked(bool) OVERRIDE;
private:
- RefPtr<Scrollbar> m_scrollbar;
+ explicit WebScrollbarImpl(Scrollbar*);
+
+ RefPtrWillBePersistent<Scrollbar> m_scrollbar;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698